Skip to content

Conversation

@zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Jan 14, 2025

Motivation

In order to more easily let users know they are running an outdated version of foundryup we should let users easily check their version

It will also help us track down issues filed by bug report

On the announcements page we will list the latest version number of foundryup (https://zerosnacks-add-announcements.foundry-book.pages.dev/announcements#how-do-i-know-which-version-i-have-installed)

Solution

  • Adds the --version command to list foundryup's version
  • Adds a request for the user to paste in their foundryup --version as part of the bug report

Reordered some commands to surface update and version up top

My proposal is that we use the major / minor version to match the latest stable release version and then increment the patch version for any updates we make after each stable release

Note: in old versions of foundryup the --version command was used for the --install functionality, this was updated as part of 0.3.0. This command will now return the version number specified by FOUNDRYUP_INSTALLER_VERSION, effectively a noop without side effects.

If you make an update to foundryup and you want users to update you should open a PR to bump the version number on the announcements page of the Foundry book here: https://zerosnacks-add-announcements.foundry-book.pages.dev/announcements#how-do-i-know-which-version-i-have-installed

@zerosnacks zerosnacks marked this pull request as ready for review January 14, 2025 11:55
Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense!

@zerosnacks zerosnacks self-assigned this Jan 14, 2025
@zerosnacks zerosnacks merged commit 41c6653 into master Jan 14, 2025
22 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/add-version-number-to-foundryup branch January 14, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

3 participants