Upgrade to xero-php-oauth2 10.x

[wireblue]

Hi there,

Are there plans to support version 10.x of xero-php-oauth2?

If no, would you be open to a PR, and what would you like to see included in that PR? I've read CONTRIBUTING.md, but wasn't sure if there was something else that makes life easier when reviewing PR's.

I can see xero-php-oauth2 9.x and 10.x included breaking changes to Employee/Employment models and API endpoints, so I imagine the PR would require a new major version of this package.

[hailwood]

Hey @wireblue,

That's a good question!

Version 9/10 of xero-php-oauth2?

We're definitely open to a PR for the newer version.
It looks like there are no authentication related changes in version 9 or 10 so we should have no breaking changes from our side, but you are correct that pulling in an updated version of the API for others could cause issues.

We'll do a new major release to support version 9 and 10.

Other Breaking Changes?

PHP 8.5 is getting released in a couple of days, so we should make this release support PHP 8.5 as well to avoid two major releases.

If you wish to provide both PRs please go ahead,
We'll need to update the composer.json as well as the test runner.

Thanks!

[wireblue]

Thanks @hailwood,

I've opened a PR for the xero-php-oauth2 upgrade.
#136

I'll send through another shortly for the PHP 8.5 upgrade. The code changes were easy, but the tests are returning deprecation errors and it's a little difficult to see exactly what they are.

I'll close this issue and continue the discussion(s) in the PR's.