Invalid_grant on xero connection

[bilalswiftsolutions]

After Every few days i am getting this error .I don't know what is the reason behind it. i have tried everything created new organisation created new app cache:cleared . still getting this error. How I can connect it again?

[AllanGallop]

Seeing this too when trying to switch Xero users, presuming it is down to an expired refresh token I tried deleting out the xero.json but just hits with the 'Xero oauth credentials are missing' exemption if the file is removed. Any clues on how to clear out credentials and reconnect?

[bilalswiftsolutions]

When i deleted xero.json then i can reconnect it again. But now the issue is we don't know it can be break anytime. without knowing reasong. our system is uploading invoices on xero automatically. and it starts failing because of this. is there any proper solution?

[hailwood]

Hi @bilalswiftsolutions & @AllanGallop,

Can you please tell me, is there a length of time between you using the Xero token? Or maybe does it always fail after 30 minutes?

The refresh tokens are supposed to be valid for 60 days so it shouldn't be expiring but I do wonder if that's the cause regardless and the Xero docs are wrong.

The fact you're getting invalid_grant errors is even stranger given that the logic for the refreshing of the tokens never changes.

I'm going to need a specific reproduction case to debug this. E.,g a certain time must pass without the token being used, or you need to make a specific call to trigger it otherwise I'm just guessing.

@SidneyAllen do you have any ideas?

[AllanGallop]

@hailwood
Please excuse me, looks like a mistake on my end. A previous users revoked token was being passed instead of the new one by an error in my logic and call to getExpires outside the try/catch in the controller. I have additionally added logic to delete the JSON file and redirect the user to /xero/auth/authorize upon hitting an invalid grant and this has resolved my issues.

[hailwood]

Great to hear it's not a package issue for you @AllanGallop and thank you for following up :)

We'll keep this issue open for a bit longer to see if we can work out what's going on for @bilalswiftsolutions.

[bilalswiftsolutions]

hi @hailwood I don't know if it is issue on my side or not.

Let me describe you scenario, I am not refreshing token anywhere don't know if it is wrong or not

I am using xero credentials on two places one is to manually upload invoice to xero

Which is working fine however it also gives error after few days. but not really early.

On second place I am using xero credentials to invoice upload automatically . This process is in queue.

This how I am connecting xero app . Please let me know if anything is wrong here

 try {
           
            // Check if we've got any stored credentials
            if ($xeroCredentials->exists()) {
            
                /* 
                 * We have stored credentials so we can resolve the AccountingApi, 
                 * If we were sure we already had some stored credentials then we could just resolve this through the controller
                 * But since we use this route for the initial authentication we cannot be sure!
                 */
           
                $xero             = $this->authKey();
                $organisationName = $xero->getOrganisations($xeroCredentials->getTenantId())->getOrganisations()[0]->getName();
                $user             = $xeroCredentials->getUser();
                $username         = "{$user['given_name']} {$user['family_name']} ({$user['username']})";
               
            }
        } catch (\throwable $e) {
            // This can happen if the credentials have been revoked or there is an error with the organisation (e.g. it's expired)
            $error = $e->getMessage();
    
        }


        return view('web.admin.pages.xero', [
            'connected'        => $xeroCredentials->exists(),
            'error'            => $error ?? null,
            'organisationName' => $organisationName ?? null,
            'username'         => $username ?? null
        ]);

And here is how I am using it in laravel job (queued process)

<?php

namespace App\Jobs\Invoice;

use App\Http\Controllers\Admin\Contacts\CustomerController;
use Illuminate\Bus\Queueable;
use Illuminate\Queue\SerializesModels;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use App\Models\Admin\Invoice;
use App\Services\Contacts\CustomerSettingService;
use Webfox\Xero\OauthCredentialManager;
class UploadInvoiceToXero implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;

    /**
     * Create a new job instance.
     *
     * @return void
     */
    protected $invoice_id;


    public function __construct($invoice_id)
    {
        $this->invoice_id = $invoice_id;
     
   
    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle(OauthCredentialManager $xeroCredential)
    {
        CustomerController::uploadAutoInvoiceToXero($this->invoice_id, $xeroCredential);

    }
}

I don't know If i need to refresh token here or not.
Please let me know if i am doing anything wrong here

Deleting xero.json file also work for me . but shouldn't be the solution as it gets uploaded in hundred automatically

[hailwood]

Hmm, That looks fine to me. And you shouldn't need to refresh the token. Every time the credential manager is resolved from the container it should be refreshing it for you.

…

On Mon, 1 Feb 2021, 18:51 Bilal Arshad, ***@***.***> wrote: hi @hailwood <https://github.com/hailwood> I don't know if it is issue on my side or not. Let me describe you scenario, I am not refreshing token anywhere don't know if it is wrong or not I am using xero credentials on two places one is to manually upload invoice to xero Which is working fine however it also gives error after few days. but not really early. On second place I am using xero credentials to invoice upload automatically . This process is in queue. This how I am connecting xero app . Please let me know if anything is wrong here try { // Check if we've got any stored credentials if ($xeroCredentials->exists()) { /* * We have stored credentials so we can resolve the AccountingApi, * If we were sure we already had some stored credentials then we could just resolve this through the controller * But since we use this route for the initial authentication we cannot be sure! */ $xero = $this->authKey(); $organisationName = $xero->getOrganisations($xeroCredentials->getTenantId())->getOrganisations()[0]->getName(); $user = $xeroCredentials->getUser(); $username = "{$user['given_name']} {$user['family_name']} ({$user['username']})"; } } catch (\throwable $e) { // This can happen if the credentials have been revoked or there is an error with the organisation (e.g. it's expired) $error = $e->getMessage(); } return view('web.admin.pages.xero', [ 'connected' => $xeroCredentials->exists(), 'error' => $error ?? null, 'organisationName' => $organisationName ?? null, 'username' => $username ?? null ]); And here is how I am using it in laravel job (queued process) <?php namespace App\Jobs\Invoice; use App\Http\Controllers\Admin\Contacts\CustomerController; use Illuminate\Bus\Queueable; use Illuminate\Queue\SerializesModels; use Illuminate\Queue\InteractsWithQueue; use Illuminate\Contracts\Queue\ShouldQueue; use Illuminate\Foundation\Bus\Dispatchable; use App\Models\Admin\Invoice; use App\Services\Contacts\CustomerSettingService; use Webfox\Xero\OauthCredentialManager; class UploadInvoiceToXero implements ShouldQueue { use Dispatchable, InteractsWithQueue, Queueable, SerializesModels; /** * Create a new job instance. * * @return void */ protected $invoice_id; public function __construct($invoice_id) { $this->invoice_id = $invoice_id; } /** * Execute the job. * * @return void */ public function handle(OauthCredentialManager $xeroCredential) { CustomerController::uploadAutoInvoiceToXero($this->invoice_id, $xeroCredential); } } I don't know If i need to refresh token here or not. Please let me know if i am doing anything wrong here — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#48 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFNJDNPOPK4EWSGUIMWBZLS4Y6OJANCNFSM4WRG7DZA> .

[bilalswiftsolutions]

it is creating issue in Queue process I don't know why

[hailwood]

Just checking, what version are you using? As the old versions didn't resolve it each time, they should on the new versions though.

[bilalswiftsolutions]

no its latest version 2.0.*

[hailwood]

I really have no idea then sorry. Unless I can get a solid reproduction case there's not a lot I can do.

[bilalswiftsolutions]

reproduction is easy. Just use it in queue process

[hailwood]

I just re-read over your code and noticed you never seem to resolve the AccountingApi or IdentityApi so in turn never resolve the Configuration object from Xero.

I've moved the token refresh logic to happen when you resolve the credential manager.
Give that a go and let me know if it's still an issue :) v2.0.5

[bilalswiftsolutions]

ok let me check that

[bilalswiftsolutions]

ok its working fine now. Thanks a lot. it gives error after 2 to 3 days . I will reopen issue if I get any other error