Skip to content

Add PHP 8.5 support #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Add PHP 8.5 support #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [8.4, 8.3, 8.2]
php: [8.5, 8.4, 8.3, 8.2]
laravel: ['10.*', '11.*', '12.*']
stability: [prefer-lowest, prefer-stable]
include:
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
}
],
"require": {
"php": "^8.2|^8.3|^8.4",
"php": "^8.2|^8.3|^8.4|^8.5",
Copy link

@gemini-code-assist gemini-code-assist bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding support for PHP 8.5 is a good goal, this change should not be merged until the test suite passes for all supported PHP versions, including 8.5. As you've noted in the description, this change currently causes tests to fail due to deprecation warnings from dependencies. It's crucial to maintain a green build to ensure the stability and reliability of the package. I'd recommend marking this PR as a draft until the underlying dependency issues are resolved and the CI is green.

"xeroapi/xero-php-oauth2": "^7.1|^8.0",
"laravel/framework": "^10.0|^11.0|^12.0"
},
Expand Down