Handle multiple tenants in XeroAuthorized #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I was connecting my app using this library I hit an issue where the oauth credentials were throwing an error: `Undefined array key "tenant_id"` , because the structure from `$oauth->getData()` had my tenants as an array, as opposed to the single tenant_id expected:
```
dd( $oauth->getData() );
// results in
[
"token" => "asdasdasdasdasdasd"
"refresh_token" => null
"id_token" => "asdasdasdasdasdasdasdaasd"
"expires" => 1657593567
"tenants" => [
0 => [
"Id" => "asdasdasd-asdasd-asdasd-asdasd-asdasdasda"
"Name" => "Demo Company (AU)"
]
]
]
```
I'm not sure if this is a permanent API change or if the response changes depending on your Xero account settings or what, but this change allows for my integration to proceed without breaking anything else, so I thought I might as well push it!
Contributor
|
Hi @AbrahamBrookes, You're right this is definitely a bug, It was introduced in #71 by us not updating this so it is a permanent API change. Rather than setting the ID from the first tenant, can you please remove the Cheers! |
update the tenant_id property in XeroAuthorized for API change as per foxbytehq#74 (comment)
Contributor
Author
|
cool thanks! that's been updated in 334b2c3 and tested working in my project: |
Contributor
|
Thanks @AbrahamBrookes, That's now been released |
Contributor
Author
|
Legend! Aw, my first PR package pull. This calls for a celebration 🥃 |
Contributor
|
Congrats @AbrahamBrookes, It's a good feeling! |
hailwood
pushed a commit
that referenced
this pull request
Aug 12, 2024
* Handle multiple tenants in XeroAuthorized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was connecting my app using this library I hit an issue where the oauth credentials were throwing an error:
Undefined array key "tenant_id", because the structure from$oauth->getData()had my tenants as an array, as opposed to the single tenant_id expected:I'm not sure if this is a permanent API change or if the response changes depending on your Xero account settings or what, but this change allows for my integration to proceed without breaking anything else, so I thought I might as well push it!