Fix exception nulls #132
Merged
Fix exception nulls #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a few const qualifiers, so we don't have to copy again.
It didn't trigger the new logic, but an extra test case doesn't hurt.
bitonic
reviewed
Apr 25, 2022
| { | ||
| std::type_info *type_info = abi::__cxa_current_exception_type(); | ||
| if (!type_info) | ||
| return strdup("<no exception>"); |
Collaborator
There was a problem hiding this comment.
This is unrelated to the PR (it was like this to begin with), but could you update the comment in Exception.hs referencing free, while it's actually using unsafePackMallocCString, and also note here that these allocations are freed there?
Collaborator
Author
There was a problem hiding this comment.
I've pushed a bunch of comments of this sort. I think they do, but do they cover your request?
bitonic
approved these changes
Apr 26, 2022
Collaborator
Author
|
Ohh we were waiting for the CI configuration to be done. Shouldn't have merged yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentExceptionTypeNamehas crashed in what appears to beabi::__cxa_current_exception_type()->( Crash on service stop hercules-ci/hercules-ci-agent#417). This fixes at least the crash part. (It's still not pretty)Some other calls have the potential to crash similarly; also fixed.
Add a few
constso we don't have tostrdupfor no good reason. Should be uninteresting. (I tried - lazily - to keep working withchar *but the demangle function did not like that.)