fix(gmi): update tests for extracted GMI subsystems and fix case-insensitive mood matching

Author: jddunn

src/cognitive_substrate/MetapromptExecutor.ts

@@ -594,11 +594,13 @@ export class MetapromptExecutor {
 
     let stateChanged = false;
 
-    // Mood update
-    if (updates.updatedGmiMood && this.config.getMood() !== updates.updatedGmiMood) {
-      const validMoods = Object.values(GMIMood);
-      if (validMoods.includes(updates.updatedGmiMood.toUpperCase())) {
-        this.config.onMoodUpdate(updates.updatedGmiMood.toUpperCase() as GMIMood);
+    // Mood update — GMIMood enum values are lowercase (e.g., 'focused'),
+    // but LLM responses may return either case. Normalize to lowercase for comparison.
+    if (updates.updatedGmiMood) {
+      const validMoods = Object.values(GMIMood) as string[];
+      const normalizedMood = String(updates.updatedGmiMood).toLowerCase();
+      if (validMoods.includes(normalizedMood) && this.config.getMood() !== normalizedMood) {
+        this.config.onMoodUpdate(normalizedMood as GMIMood);
         stateChanged = true;
       }
     }

src/cognitive_substrate/tests/GMI.sentiment.test.ts

@@ -476,7 +476,7 @@ describe('GMI Event Detection', () => {
     for await (const _chunk of gmi.processTurnStream(input)) { /* consume */ }
 
     // Check internal event was emitted by checking eventHistory
-    const eventHistory = (gmi as any).eventHistory as Array<{ eventType: GMIEventType }>;
+    const eventHistory = (gmi as any).sentimentTracker.events as Array<{ eventType: GMIEventType }>;
     expect(eventHistory.some((e) => e.eventType === GMIEventType.USER_FRUSTRATED)).toBe(true);
   });
 
@@ -500,7 +500,7 @@ describe('GMI Event Detection', () => {
 
     for await (const _chunk of gmi.processTurnStream(input)) { /* consume */ }
 
-    const eventHistory = (gmi as any).eventHistory as Array<{ eventType: GMIEventType }>;
+    const eventHistory = (gmi as any).sentimentTracker.events as Array<{ eventType: GMIEventType }>;
     expect(eventHistory.some((e) => e.eventType === GMIEventType.USER_CONFUSED)).toBe(true);
   });
 
@@ -524,7 +524,7 @@ describe('GMI Event Detection', () => {
 
     for await (const _chunk of gmi.processTurnStream(input)) { /* consume */ }
 
-    const eventHistory = (gmi as any).eventHistory as Array<{ eventType: GMIEventType }>;
+    const eventHistory = (gmi as any).sentimentTracker.events as Array<{ eventType: GMIEventType }>;
     expect(eventHistory.some((e) => e.eventType === GMIEventType.USER_SATISFIED)).toBe(true);
   });
 
@@ -548,7 +548,7 @@ describe('GMI Event Detection', () => {
 
     for await (const _chunk of gmi.processTurnStream(input)) { /* consume */ }
 
-    const eventHistory = (gmi as any).eventHistory as Array<{ eventType: GMIEventType }>;
+    const eventHistory = (gmi as any).sentimentTracker.events as Array<{ eventType: GMIEventType }>;
     expect(eventHistory.some((e) => e.eventType === GMIEventType.USER_FRUSTRATED)).toBe(false);
   });
 
@@ -576,7 +576,7 @@ describe('GMI Event Detection', () => {
 
     for await (const _chunk of gmi.processTurnStream(input)) { /* consume */ }
 
-    const eventHistory = (gmi as any).eventHistory as Array<{ eventType: GMIEventType }>;
+    const eventHistory = (gmi as any).sentimentTracker.events as Array<{ eventType: GMIEventType }>;
     expect(eventHistory.some((e) => e.eventType === GMIEventType.USER_FRUSTRATED)).toBe(true);
   });
 });
@@ -686,7 +686,7 @@ describe('GMI Metaprompt Trigger System', () => {
     for await (const _chunk of gmi.processTurnStream(input)) { /* consume */ }
 
     // Verify event was emitted to history (diagnostic check)
-    const eventHistory = (gmi as any).eventHistory;
+    const eventHistory = (gmi as any).sentimentTracker.events;
     expect(eventHistory.some((e: any) => e.eventType === GMIEventType.USER_FRUSTRATED)).toBe(true);
 
     // Verify the reasoning trace shows the metaprompt was triggered