Skip to content

Commit 404e328

Browse files
committed
fix(ci): postgres adapter capabilities + drop unused vars
RecordingPostgresAdapter was missing the new `capabilities` field on StorageAdapter, which broke `tsc --noEmit` and the Test & Lint job. Also drops the imports/locals AgentOSOrchestrator and agency.ts no longer reference (GMIManager, ConversationManager, AdaptiveExecutionDecision, PreparedTurnContext, TaskOutcomeStatus, LongTermMemoryRetrievalState, TurnExecutionLifecyclePhase, longTermMemoryPolicy, longTermMemoryRetrievalDiagnostics, lastResult) to clear the lint annotations the same job was emitting.
1 parent 01ea3ff commit 404e328

3 files changed

Lines changed: 12 additions & 27 deletions

File tree

src/api/agency.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,14 +234,12 @@ export function agency(opts: AgencyOptions): Agent {
234234
const hasValidation = !!opts.output;
235235

236236
let currentPrompt = preparedPrompt;
237-
let lastResult: Record<string, unknown> | null = null;
238237
let lastFinalized: FinalizedExecutionResult | null = null;
239238

240239
const maxAttempts = hasValidation ? maxValidationRetries + 1 : 1;
241240

242241
for (let attempt = 1; attempt <= maxAttempts; attempt++) {
243242
const result = (await strategy.execute(currentPrompt, execOpts)) as Record<string, unknown>;
244-
lastResult = result;
245243
const finalized = await finalizeExecutionResult(result, start, sessionId);
246244
lastFinalized = finalized;
247245

src/api/runtime/AgentOSOrchestrator.ts

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import {
1515
resolveTaskOutcomeTelemetryConfig,
1616
resolveAdaptiveExecutionConfig,
1717
type TaskOutcomeAssessment,
18-
type AdaptiveExecutionDecision,
1918
type ResolvedTaskOutcomeTelemetryConfig,
2019
type ResolvedAdaptiveExecutionConfig,
2120
} from './TaskOutcomeTelemetryManager';
@@ -31,13 +30,11 @@ import type {
3130
} from '../types/AgentOSExternalToolRequest';
3231
// AGENTOS_PENDING_EXTERNAL_TOOL_REQUEST_METADATA_KEY now used only by ExternalToolResultHandler
3332
import type { AgentOSToolResultInput } from '../types/AgentOSToolResult';
34-
import { GMIManager } from '../../cognitive_substrate/GMIManager';
3533
import {
3634
IGMI,
3735
GMIOutput,
3836
GMIOutputChunkType,
3937
} from '../../cognitive_substrate/IGMI';
40-
import { ConversationManager } from '../../core/conversation/ConversationManager';
4138
import { ConversationContext } from '../../core/conversation/ConversationContext';
4239
import { MessageRole } from '../../core/conversation/ConversationMessage';
4340
// IToolOrchestrator — referenced via AgentOSOrchestratorDependencies
@@ -55,9 +52,7 @@ import {
5552
} from '../../core/conversation/RollingSummaryCompactor';
5653
// IRollingSummaryMemorySink, RollingSummaryMemoryUpdate — now used by TurnExecutionPipeline
5754
// ILongTermMemoryRetriever — referenced via AgentOSOrchestratorDependencies
58-
import {
59-
type ResolvedLongTermMemoryPolicy,
60-
} from '../../core/conversation/LongTermMemoryPolicy';
55+
// ResolvedLongTermMemoryPolicy — referenced via TurnExecutionPipeline
6156
import {
6257
recordAgentOSTurnMetrics,
6358
recordExceptionOnActiveSpan,
@@ -69,7 +64,7 @@ import {
6964
// CapabilityContextAssembler, filterCapabilityDiscoveryResultByDisabledSkills — now used by GMIChunkTransformer
7065
import { ExternalToolResultHandler } from './ExternalToolResultHandler';
7166
import { GMIChunkTransformer } from './GMIChunkTransformer';
72-
import { TurnExecutionPipeline, type PreparedTurnContext } from './TurnExecutionPipeline';
67+
import { TurnExecutionPipeline } from './TurnExecutionPipeline';
7368

7469
// Public config types extracted to types/OrchestratorConfig.ts
7570
export type {
@@ -115,8 +110,6 @@ type ResolvedTenantRoutingConfig = {
115110
// TaskOutcomeAssessment, TaskOutcomeKpiSummary, TaskOutcomeKpiAlert,
116111
// AdaptiveExecutionDecision — imported from TaskOutcomeTelemetryManager
117112

118-
type TaskOutcomeStatus = 'success' | 'partial' | 'failed';
119-
120113
// TaskOutcomeKpiWindowEntry imported from types/OrchestratorConfig.ts
121114

122115
// AdaptiveExecutionDecision imported from TaskOutcomeTelemetryManager
@@ -273,19 +266,6 @@ function buildToolCallChunkMetadata(
273266
return metadata;
274267
}
275268

276-
type LongTermMemoryRetrievalState = {
277-
lastReviewedUserTurn: number;
278-
lastReviewedAt?: number;
279-
};
280-
281-
type TurnExecutionLifecyclePhase =
282-
| 'planned'
283-
| 'executing'
284-
| 'degraded'
285-
| 'recovered'
286-
| 'completed'
287-
| 'errored';
288-
289269
type ResolvedAgentOSOrchestratorConfig = Required<
290270
Omit<
291271
AgentOSOrchestratorConfig,
@@ -703,7 +683,6 @@ export class AgentOSOrchestrator {
703683
let currentPersonaId = input.selectedPersonaId;
704684
let gmiInstanceIdForChunks = 'gmi_pending_init';
705685
let organizationIdForMemory: string | undefined;
706-
let longTermMemoryPolicy: ResolvedLongTermMemoryPolicy | null = null;
707686
let didForceTerminate = false;
708687
let lifecycleDegraded = false;
709688
let keepStreamContextActive = false;
@@ -718,13 +697,11 @@ export class AgentOSOrchestrator {
718697
currentPersonaId = prepared.currentPersonaId;
719698
gmiInstanceIdForChunks = prepared.gmiInstanceIdForChunks;
720699
organizationIdForMemory = prepared.organizationIdForMemory;
721-
longTermMemoryPolicy = prepared.longTermMemoryPolicy;
722700
lifecycleDegraded = prepared.lifecycleDegraded;
723701
turnMetricsPersonaId = currentPersonaId;
724702

725703
const { gmiInput, streamContext } = prepared;
726704
const longTermMemoryFeedbackPayload = prepared.longTermMemoryFeedbackPayload;
727-
const longTermMemoryRetrievalDiagnostics = prepared.longTermMemoryRetrievalDiagnostics;
728705

729706
let currentToolCallIteration = 0;
730707
let continueProcessing = true;

src/memory/retrieval/store/__tests__/Brain.postgres-ddl.test.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,23 @@
11
import { describe, expect, it } from 'vitest';
22
import type {
33
StorageAdapter,
4+
StorageCapability,
45
StorageParameters,
56
StorageRunResult,
67
} from '@framers/sql-storage-adapter';
78
import { Brain } from '../Brain.js';
89

910
class RecordingPostgresAdapter implements StorageAdapter {
1011
readonly kind = 'postgres' as const;
12+
readonly capabilities: ReadonlySet<StorageCapability> = new Set<StorageCapability>([
13+
'transactions',
14+
'locks',
15+
'persistence',
16+
'concurrent',
17+
'json',
18+
'arrays',
19+
'prepared',
20+
]);
1121
readonly execStatements: string[] = [];
1222

1323
async open(): Promise<void> {}

0 commit comments

Comments
 (0)