memory(test): fix typecheck — test stubs cast as interface at usage sites, PADState from core/config

Author: jddunn

src/memory/retrieval/hybrid/__tests__/HybridRetriever.integration.spec.ts

@@ -7,7 +7,10 @@ import type { IEmbeddingManager } from '../../../../core/embeddings/IEmbeddingMa
 import type { MemoryTrace, MemoryScope } from '../../../core/types.js';
 import type { PADState } from '../../../core/config.js';
 
-class HashEmbedder implements IEmbeddingManager {
+// Test stubs: use structural typing + `as unknown as IEmbeddingManager` at
+// construction sites below. Interfaces have methods (initialize,
+// getEmbeddingModelInfo, checkHealth) we don't need for these tests.
+class HashEmbedder {
   async generateEmbeddings(input: { texts: string | string[] }) {
     const texts = Array.isArray(input.texts) ? input.texts : [input.texts];
     const embeddings = texts.map((t) => {
@@ -26,7 +29,7 @@ class HashEmbedder implements IEmbeddingManager {
   getModel() { return 'hash'; }
 }
 
-class NoopKG implements IKnowledgeGraph {
+class NoopKG {
   async recordMemory() { return 'noop'; }
   async findRelatedMemories() { return []; }
   async findEntityRelationships() { return []; }
@@ -67,7 +70,7 @@ describe('HybridRetriever (integration)', () => {
     const traceVectorStore = await mkVectorStore();
     const memoryStore = new MemoryStore({
       vectorStore: traceVectorStore,
-      embeddingManager: embedder,
+      embeddingManager: embedder as unknown as IEmbeddingManager,
       knowledgeGraph: new NoopKG() as unknown as IKnowledgeGraph,
       collectionPrefix: 'cogmem',
     });
@@ -94,7 +97,7 @@ describe('HybridRetriever (integration)', () => {
     const embedder = new HashEmbedder();
     const memoryStore = new MemoryStore({
       vectorStore: await mkVectorStore(),
-      embeddingManager: embedder,
+      embeddingManager: embedder as unknown as IEmbeddingManager,
       knowledgeGraph: new NoopKG() as unknown as IKnowledgeGraph,
       collectionPrefix: 'cogmem',
     });

src/memory/retrieval/session/__tests__/SessionRetriever.integration.spec.ts

@@ -5,9 +5,13 @@ import { MemoryStore } from '../../store/MemoryStore.js';
 import { InMemoryVectorStore } from '../../../../rag/vector_stores/InMemoryVectorStore.js';
 import type { IKnowledgeGraph } from '../../graph/knowledge/IKnowledgeGraph.js';
 import type { IEmbeddingManager } from '../../../../core/embeddings/IEmbeddingManager.js';
-import type { MemoryTrace, PADState, MemoryScope } from '../../../core/types.js';
+import type { MemoryTrace, MemoryScope } from '../../../core/types.js';
+import type { PADState } from '../../../core/config.js';
 
-class HashEmbedder implements IEmbeddingManager {
+// Test stubs: use structural typing + `as unknown as IEmbeddingManager`
+// at construction sites. Interfaces have methods (initialize,
+// getEmbeddingModelInfo, checkHealth) we don't need for these tests.
+class HashEmbedder {
   async generateEmbeddings(input: { texts: string | string[] }) {
     const texts = Array.isArray(input.texts) ? input.texts : [input.texts];
     const embeddings = texts.map((t) => {
@@ -26,7 +30,7 @@ class HashEmbedder implements IEmbeddingManager {
   getModel() { return 'hash'; }
 }
 
-class NoopKG implements IKnowledgeGraph {
+class NoopKG {
   async recordMemory() { return 'noop'; }
   async findRelatedMemories() { return []; }
   async findEntityRelationships() { return []; }
@@ -63,7 +67,7 @@ const scope = { scope: 'user' as MemoryScope, scopeId: 'u1' };
 
 describe('SessionRetriever (integration)', () => {
   it('end-to-end: index 3 session summaries, encode chunks, retrieve returns at least one chunk', async () => {
-    const embedder = new HashEmbedder();
+    const embedder = new HashEmbedder() as unknown as IEmbeddingManager;
     const traceVectorStore = await mkVectorStore();
     const summaryVectorStore = await mkVectorStore();
     const summaryStore = new SessionSummaryStore({
@@ -114,7 +118,7 @@ describe('SessionRetriever (integration)', () => {
   });
 
   it('cache smoke: two retrieve calls with the same query return stable results', async () => {
-    const embedder = new HashEmbedder();
+    const embedder = new HashEmbedder() as unknown as IEmbeddingManager;
     const summaryStore = new SessionSummaryStore({
       vectorStore: await mkVectorStore(), embeddingManager: embedder,
     });

src/memory/retrieval/session/__tests__/SessionRetriever.spec.ts

@@ -4,9 +4,9 @@ import { SessionSummaryStore } from '../SessionSummaryStore.js';
 import type {
   ScoredMemoryTrace,
   CognitiveRetrievalOptions,
-  PADState,
   MemoryScope,
 } from '../../../core/types.js';
+import type { PADState } from '../../../core/config.js';
 
 class FakeSummaryStore {
   constructor(private sessions: Array<{ sessionId: string; similarity: number }> = []) {}

src/memory/retrieval/session/__tests__/SessionSummaryStore.spec.ts

@@ -3,7 +3,8 @@ import { SessionSummaryStore } from '../SessionSummaryStore.js';
 import { InMemoryVectorStore } from '../../../../rag/vector_stores/InMemoryVectorStore.js';
 import type { IEmbeddingManager } from '../../../../core/embeddings/IEmbeddingManager.js';
 
-class FakeEmbedder implements IEmbeddingManager {
+// Test stub: cast at usage site below via `as unknown as IEmbeddingManager`.
+class FakeEmbedder {
   async generateEmbeddings(input: { texts: string | string[] }) {
     const texts = Array.isArray(input.texts) ? input.texts : [input.texts];
     const embeddings = texts.map((t) => {
@@ -29,7 +30,7 @@ async function mkStore(): Promise<SessionSummaryStore> {
     defaultEmbeddingDimension: 8,
     similarityMetric: 'cosine',
   } as import('../../../../core/vector-store/IVectorStore.js').VectorStoreProviderConfig);
-  return new SessionSummaryStore({ vectorStore, embeddingManager: new FakeEmbedder() });
+  return new SessionSummaryStore({ vectorStore, embeddingManager: new FakeEmbedder() as unknown as IEmbeddingManager });
 }
 
 describe('SessionSummaryStore', () => {