Skip to content

Commit af94abb

Browse files
committed
docs(memory/typed-network): expand W/E/O/S abbreviation to full bank names
Test description and schema TSDoc both used W/E/O/S which is the Hindsight paper §2.2 notation (𝒲/ℬ/𝒪/𝒮 with script-S for Observation) but ambiguous in plain text since two banks start with O. Use the full enum values in both places for self-explaining docs.
1 parent 9687f05 commit af94abb

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/memory/retrieval/typed-network/__tests__/TypedNetworkObserver.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ describe('TypedNetworkObserver', () => {
8686
expect(facts).toEqual([]);
8787
});
8888

89-
it('drops fact with bank label that does not coerce to W/E/O/S', async () => {
89+
it('drops fact with bank label that does not coerce to WORLD/EXPERIENCE/OPINION/OBSERVATION', async () => {
9090
const llm = mockLLM(JSON.stringify({
9191
facts: [{
9292
text: 'foo',

src/memory/retrieval/typed-network/prompts/extraction-schema.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,10 @@
2525
* The model frequently emits the fact without these keys when no
2626
* participants/entities/markers apply.
2727
*
28-
* Per-fact failures (text below minimum length, bank not in W/E/O/S
29-
* after uppercase coercion, confidence outside [0, 1]) still cause the
30-
* INDIVIDUAL fact to drop. The {@link TypedNetworkObserver} validates
28+
* Per-fact failures (text below minimum length, bank not in
29+
* WORLD/EXPERIENCE/OPINION/OBSERVATION after uppercase coercion,
30+
* confidence outside [0, 1]) still cause the INDIVIDUAL fact to drop.
31+
* The {@link TypedNetworkObserver} validates
3132
* facts one by one (`safeParse` per fact) and keeps the valid ones.
3233
*
3334
* @module @framers/agentos/memory/retrieval/typed-network/prompts/extraction-schema

0 commit comments

Comments
 (0)