-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds 'use_collision_mesh' arg to the robot description #154
Conversation
I can of course also change the name of the variable to, for example, |
This commits gives users the ability to load the `robot_description` urdf with the collision meshes instead of the collision geometries.
c171cfb
to
3c27c38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 As a user, I definitely want to have an option to resort to these fine-grained meshes.
Is there an option to disable the internal self-collision checking of the robot controller (and only rely on planning methods)?
As Franka pointed out that the internal self-collision checking cannot be disabled or changed by any means, it doesn't make sense to plan with the detailed meshes. However, for environmental collisions, the same problem arises as for the hand: While planning might fail with the coarse self-collision models, the robot might perfectly fit into a narrow passage with the detailed meshes. I think, this PR here, can be closed. |
Makes sense. Do you want to extend #189 or create a separate pull request? |
See #199 😉 |
This commits gives users the ability to load the
robot_description
urdf
with the collision meshes instead of the collision geometries. This is for example useful if people want to use less strict Mesh-based collision properties for third party planners in their packages.For the moveit_tutorials for example, the movement with the geometry messes is to course (see moveit/panda_moveit_config#72 (comment)). In that case, or the geometries need to be improved or we might want to use the meshes instead.