Skip to content

Fix phpstan codequality inspection #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2025
Merged

Fix phpstan codequality inspection #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40d07c8
Fix phpstan codequality inspection
frankdekker May 11, 2025
125ba73
Update baseline
frankdekker May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
"symfony/http-client": "Required for the remote hosts feature"
},
"scripts": {
"baseline:phpstan": "@php vendor/bin/phpstan --generate-baseline",
"check": ["@check:phpstan", "@check:phpmd", "@check:phpcs"],
"check:phpstan": "phpstan analyse",
"check:phpmd": "phpmd src,tests text phpmd.xml.dist",
Expand Down
6 changes: 6 additions & 0 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,12 @@ parameters:
count: 1
path: src/DependencyInjection/Extension.php

-
message: '#^Property FD\\LogViewer\\Reader\\Stream\\AbstractStreamReader\:\:\$autoClose in isset\(\) is not nullable nor uninitialized\.$#'
identifier: isset.initializedProperty
count: 1
path: src/Reader/Stream/AbstractStreamReader.php

-
message: '#^Method FD\\LogViewer\\Reader\\String\\StringReader\:\:eol\(\) is marked as impure but does not have any side effects\.$#'
identifier: impureMethod.pure
Expand Down