fix: incorrect rate in BOM exploded items #31513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing tests are not related #88e2b04 |
marination
reviewed
Jul 6, 2022
|
@s-aga-r You can make the rate field read only and add a test to change qty in items table and check reflected changes in the exploded items table on save. |
s-aga-r
force-pushed
the
fix/bom/exploded-items/rate
branch
from
88e2b04
to
00c1317
Compare
Codecov Report
@@ Coverage Diff @@
## develop #31513 +/- ##
===========================================
+ Coverage 63.10% 63.21% +0.10%
===========================================
Files 813 813
Lines 57530 57530
===========================================
+ Hits 36307 36366 +59
+ Misses 21223 21164 -59
|
s-aga-r
added
backport version-13-hotfix
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
(cherry picked from commit 313625c)
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
(cherry picked from commit 313625c) # Conflicts: # erpnext/manufacturing/doctype/bom_item/bom_item.json
s-aga-r
added a commit
that referenced
this pull request
Aug 17, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
## [13.36.4](v13.36.3...v13.36.4) (2022-08-18) ### Bug Fixes * check item_code in all rows of po_items (backport [#31741](#31741)) ([#31843](#31843)) ([ba8dc89](ba8dc89)) * conflicts ([41b8563](41b8563)) * contact search in request for quotation (backport [#31828](#31828)) ([#31841](#31841)) ([2a615af](2a615af)) * incorrect produced-qty in production-plan-item (backport [#31706](#31706)) ([#31862](#31862)) ([7ddb332](7ddb332)) * incorrect rate in BOM exploded items (backport [#31513](#31513)) ([#31865](#31865)) ([3274e76](3274e76)) * Make expense account editable in Purchase Receipt Item (backport [#31730](#31730)) ([#31879](#31879)) ([4775c42](4775c42)) * not able to issue expired batches ([7ee75ff](7ee75ff)) * set `billing_address` for purchases in `get_party_details` ([a7d66fa](a7d66fa)) * set `company_address` for purchases in `party.js` ([d1de4b0](d1de4b0)) * Transit filter for Default Target Warehouse in SE (backport [#31839](#31839)) ([#31874](#31874)) ([b0917aa](b0917aa)) * use old style for `_dict.update` ([15654aa](15654aa))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
## [14.0.1](v14.0.0...v14.0.1) (2022-08-18) ### Bug Fixes * add asset repair to accounting dimension list ([65bb1d8](65bb1d8)) * Add dimension section in subcontracting doctypes (backport [#31849](#31849)) ([#31877](#31877)) ([50ad612](50ad612)) * check item_code in all rows of po_items (backport [#31741](#31741)) ([#31842](#31842)) ([82f1dd2](82f1dd2)) * contact search in request for quotation (backport [#31828](#31828)) ([#31840](#31840)) ([74664a3](74664a3)) * delete custom fields on deletion of inventory dimension ([354a9d6](354a9d6)) * **ecommerce:** remove query to non-existing field (backport [#31771](#31771)) ([#31773](#31773)) ([8737c10](8737c10)) * getting error to show sales invoice group or print rep… (backport [#31756](#31756)) ([#31767](#31767)) ([53b9d61](53b9d61)) * incorrect produced-qty in production-plan-item (backport [#31706](#31706)) ([#31861](#31861)) ([010a0ca](010a0ca)) * incorrect rate in BOM exploded items (backport [#31513](#31513)) ([#31864](#31864)) ([abe1894](abe1894)) * intercompany SO throws exception ([1d1f12f](1d1f12f)) * linter (backport [#31763](#31763)) ([#31766](#31766)) ([3092131](3092131)) * Make expense account editable in Purchase Receipt Item (backport [#31730](#31730)) ([#31878](#31878)) ([b637d4d](b637d4d)) * Make expense account editable in Subcontracting Receipt Item (backport [#31848](#31848)) ([#31870](#31870)) ([aa5aaa1](aa5aaa1)) * not able to issue expired batches ([ce5fc5b](ce5fc5b)) * posting_date of linked vouchers should not affect outstanding ([0faa7b0](0faa7b0)) * **projects:** Add missing comma ([623f56a](623f56a)) * set `billing_address` for purchases in `get_party_details` ([5a28ba8](5a28ba8)) * set `company_address` for purchases in `party.js` ([4c82533](4c82533)) * specify allowed doctype in queries (backport [#31761](#31761)) ([#31764](#31764)) ([6dce122](6dce122)) * Transit filter for Default Target Warehouse in SE (backport [#31839](#31839)) ([#31873](#31873)) ([04d3571](04d3571))
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
…appe#31865) * fix: incorrect rate in BOM exploded items (frappe#31513) (cherry picked from commit 313625c) # Conflicts: # erpnext/manufacturing/doctype/bom_item/bom_item.json * chore: conflicts Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
## [13.36.4](frappe/erpnext@v13.36.3...v13.36.4) (2022-08-18) ### Bug Fixes * check item_code in all rows of po_items (backport [frappe#31741](frappe#31741)) ([frappe#31843](frappe#31843)) ([ba8dc89](frappe@ba8dc89)) * conflicts ([41b8563](frappe@41b8563)) * contact search in request for quotation (backport [frappe#31828](frappe#31828)) ([frappe#31841](frappe#31841)) ([2a615af](frappe@2a615af)) * incorrect produced-qty in production-plan-item (backport [frappe#31706](frappe#31706)) ([frappe#31862](frappe#31862)) ([7ddb332](frappe@7ddb332)) * incorrect rate in BOM exploded items (backport [frappe#31513](frappe#31513)) ([frappe#31865](frappe#31865)) ([3274e76](frappe@3274e76)) * Make expense account editable in Purchase Receipt Item (backport [frappe#31730](frappe#31730)) ([frappe#31879](frappe#31879)) ([4775c42](frappe@4775c42)) * not able to issue expired batches ([7ee75ff](frappe@7ee75ff)) * set `billing_address` for purchases in `get_party_details` ([a7d66fa](frappe@a7d66fa)) * set `company_address` for purchases in `party.js` ([d1de4b0](frappe@d1de4b0)) * Transit filter for Default Target Warehouse in SE (backport [frappe#31839](frappe#31839)) ([frappe#31874](frappe#31874)) ([b0917aa](frappe@b0917aa)) * use old style for `_dict.update` ([15654aa](frappe@15654aa))
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploded Item rate showing incorrect value in the saved state.
Screen.Recording.2022-07-04.at.2.56.06.PM.mov