Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add dimension section in subcontracting doctypes #31849

Merged
merged 2 commits into from Aug 18, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Aug 15, 2022

No description provided.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 15, 2022
@s-aga-r s-aga-r removed the request for review from nextchamp-saqib August 15, 2022 09:26
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Aug 15, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #31849 (0337ec3) into develop (2d04e71) will increase coverage by 0.20%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #31849      +/-   ##
===========================================
+ Coverage    63.36%   63.57%   +0.20%     
===========================================
  Files          813      813              
  Lines        57560    57560              
===========================================
+ Hits         36471    36591     +120     
+ Misses       21089    20969     -120     
Impacted Files Coverage Δ
erpnext/hooks.py 100.00% <ø> (ø)
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-15.91%) ⬇️
erpnext/accounts/party.py 77.71% <0.00%> (-4.46%) ⬇️
erpnext/support/doctype/issue/issue.py 64.28% <0.00%> (-0.96%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 61.36% <0.00%> (-0.46%) ⬇️
.../report/stock_projected_qty/stock_projected_qty.py 88.15% <0.00%> (ø)
...stock/doctype/purchase_receipt/purchase_receipt.py 93.11% <0.00%> (+0.25%) ⬆️
erpnext/projects/doctype/project/project.py 51.77% <0.00%> (+0.32%) ⬆️
erpnext/accounts/report/financial_statements.py 33.33% <0.00%> (+0.38%) ⬆️
erpnext/stock/report/stock_ageing/stock_ageing.py 95.23% <0.00%> (+0.47%) ⬆️
... and 27 more

@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label Aug 17, 2022
@s-aga-r s-aga-r merged commit 8704ca7 into frappe:develop Aug 18, 2022
mergify bot pushed a commit that referenced this pull request Aug 18, 2022
(cherry picked from commit 8704ca7)

# Conflicts:
#	erpnext/patches.txt
s-aga-r added a commit that referenced this pull request Aug 18, 2022
… (#31877)

* fix: Add dimension section in subcontracting doctypes (#31849)

(cherry picked from commit 8704ca7)

# Conflicts:
#	erpnext/patches.txt

* chore: conflicts

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 18, 2022
## [14.0.1](v14.0.0...v14.0.1) (2022-08-18)

### Bug Fixes

* add asset repair to accounting dimension list ([65bb1d8](65bb1d8))
* Add dimension section in subcontracting doctypes (backport [#31849](#31849)) ([#31877](#31877)) ([50ad612](50ad612))
* check item_code in all rows of po_items (backport [#31741](#31741)) ([#31842](#31842)) ([82f1dd2](82f1dd2))
* contact search in request for quotation (backport [#31828](#31828)) ([#31840](#31840)) ([74664a3](74664a3))
* delete custom fields on deletion of inventory dimension ([354a9d6](354a9d6))
* **ecommerce:** remove query to non-existing field (backport [#31771](#31771)) ([#31773](#31773)) ([8737c10](8737c10))
* getting error to show sales invoice group or print rep… (backport [#31756](#31756)) ([#31767](#31767)) ([53b9d61](53b9d61))
* incorrect produced-qty in production-plan-item (backport [#31706](#31706)) ([#31861](#31861)) ([010a0ca](010a0ca))
* incorrect rate in BOM exploded items (backport [#31513](#31513)) ([#31864](#31864)) ([abe1894](abe1894))
* intercompany SO throws exception ([1d1f12f](1d1f12f))
* linter (backport [#31763](#31763)) ([#31766](#31766)) ([3092131](3092131))
* Make expense account editable in Purchase Receipt Item (backport [#31730](#31730)) ([#31878](#31878)) ([b637d4d](b637d4d))
* Make expense account editable in Subcontracting Receipt Item (backport [#31848](#31848)) ([#31870](#31870)) ([aa5aaa1](aa5aaa1))
* not able to issue expired batches ([ce5fc5b](ce5fc5b))
* posting_date of linked vouchers should not affect outstanding ([0faa7b0](0faa7b0))
* **projects:** Add missing comma ([623f56a](623f56a))
* set `billing_address` for purchases in `get_party_details` ([5a28ba8](5a28ba8))
* set `company_address` for purchases in `party.js` ([4c82533](4c82533))
* specify allowed doctype in queries (backport [#31761](#31761)) ([#31764](#31764)) ([6dce122](6dce122))
* Transit filter for Default Target Warehouse in SE (backport [#31839](#31839)) ([#31873](#31873)) ([04d3571](04d3571))
@s-aga-r s-aga-r added bug and removed backport version-14-hotfix backport to version 14 labels Sep 21, 2022
@barredterra barredterra mentioned this pull request Mar 7, 2023
@s-aga-r s-aga-r deleted the fix/subcontracting/ad branch April 15, 2023 10:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants