Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make expense account editable in Purchase Receipt Item #31730

Merged
merged 4 commits into from Aug 18, 2022
Merged

fix: Make expense account editable in Purchase Receipt Item #31730

merged 4 commits into from Aug 18, 2022

Conversation

deepeshgarg007
Copy link
Member

No description provided.

@deepeshgarg007 deepeshgarg007 changed the title fix: Make expense account editable in Purchase Receipt fix: Make expense account editable in Purchase Receipt Item Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited

Codecov Report

Merging #31730 (46bcd73) into develop (2d04e71) will decrease coverage by 0.26%.
The diff coverage is n/a.

❗ Current head 46bcd73 differs from pull request most recent head f1d450d. Consider uploading reports for the commit f1d450d to get more accurate results

@@             Coverage Diff             @@
##           develop   #31730      +/-   ##
===========================================
- Coverage    63.36%   63.09%   -0.27%     
===========================================
  Files          813      813              
  Lines        57560    57560              
===========================================
- Hits         36471    36318     -153     
- Misses       21089    21242     +153
Impacted Files Coverage Δ
...unts/report/purchase_register/purchase_register.py 34.21% <0.00%> (-42.77%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...e_purchase_register/item_wise_purchase_register.py 57.42% <0.00%> (-19.81%) ⬇️
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-15.91%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 50.45% <0.00%> (-11.37%) ⬇️
erpnext/stock/report/stock_ledger/stock_ledger.py 75.79% <0.00%> (-2.55%) ⬇️
erpnext/stock/doctype/item_price/item_price.py 92.98% <0.00%> (-1.76%) ⬇️
...t/accounts/report/sales_register/sales_register.py 73.68% <0.00%> (-1.17%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 71.33% <0.00%> (-1.12%) ⬇️
...cial_statement/consolidated_financial_statement.py 88.78% <0.00%> (-0.94%) ⬇️
... and 13 more

@stale stale bot added the inactive label Aug 14, 2022
@frappe frappe deleted a comment from stale bot Aug 15, 2022
@s-aga-r s-aga-r removed the inactive label Aug 15, 2022
@s-aga-r s-aga-r self-assigned this Aug 17, 2022
@s-aga-r s-aga-r merged commit 1a65089 into frappe:develop Aug 18, 2022
mergify bot pushed a commit that referenced this pull request Aug 18, 2022
@deepeshgarg007 @mergify
fix: Make expense account editable in Purchase Receipt Item (#31730)
b525239 
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
(cherry picked from commit 1a65089)
@mergify mergify bot mentioned this pull request Aug 18, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 18, 2022
@deepeshgarg007 @mergify
fix: Make expense account editable in Purchase Receipt Item (#31730)
533764b 
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
(cherry picked from commit 1a65089)

# Conflicts:
#	erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json
@mergify mergify bot mentioned this pull request Aug 18, 2022
Merged
s-aga-r added a commit that referenced this pull request Aug 18, 2022
@mergify @deepeshgarg007 @s-aga-r
fix: Make expense account editable in Purchase Receipt Item (backport #…
4775c42 
…31730) (#31879)

* fix: Make expense account editable in Purchase Receipt Item (#31730)

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
(cherry picked from commit 1a65089)

# Conflicts:
#	erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json

* chore: conflicts

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
s-aga-r pushed a commit that referenced this pull request Aug 18, 2022
@mergify @deepeshgarg007
fix: Make expense account editable in Purchase Receipt Item (backport #…
b637d4d 
…31730) (#31878)

fix: Make expense account editable in Purchase Receipt Item (#31730)

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
(cherry picked from commit 1a65089)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 18, 2022
@frappe-bot
chore(release): Bumped to Version 13.36.4
bafa3ce 
## [13.36.4](v13.36.3...v13.36.4) (2022-08-18)

### Bug Fixes

* check item_code in all rows of po_items (backport [#31741](#31741)) ([#31843](#31843)) ([ba8dc89](ba8dc89))
* conflicts ([41b8563](41b8563))
* contact search in request for quotation (backport [#31828](#31828)) ([#31841](#31841)) ([2a615af](2a615af))
* incorrect produced-qty in production-plan-item (backport [#31706](#31706)) ([#31862](#31862)) ([7ddb332](7ddb332))
* incorrect rate in BOM exploded items (backport [#31513](#31513)) ([#31865](#31865)) ([3274e76](3274e76))
* Make expense account editable in Purchase Receipt Item (backport [#31730](#31730)) ([#31879](#31879)) ([4775c42](4775c42))
* not able to issue expired batches ([7ee75ff](7ee75ff))
* set `billing_address` for purchases in `get_party_details` ([a7d66fa](a7d66fa))
* set `company_address` for purchases in `party.js` ([d1de4b0](d1de4b0))
* Transit filter for Default Target Warehouse in SE (backport [#31839](#31839)) ([#31874](#31874)) ([b0917aa](b0917aa))
* use old style for `_dict.update` ([15654aa](15654aa))
frappe-pr-bot pushed a commit that referenced this pull request Aug 18, 2022
@frappe-bot
chore(release): Bumped to Version 14.0.1
028e939 
## [14.0.1](v14.0.0...v14.0.1) (2022-08-18)

### Bug Fixes

* add asset repair to accounting dimension list ([65bb1d8](65bb1d8))
* Add dimension section in subcontracting doctypes (backport [#31849](#31849)) ([#31877](#31877)) ([50ad612](50ad612))
* check item_code in all rows of po_items (backport [#31741](#31741)) ([#31842](#31842)) ([82f1dd2](82f1dd2))
* contact search in request for quotation (backport [#31828](#31828)) ([#31840](#31840)) ([74664a3](74664a3))
* delete custom fields on deletion of inventory dimension ([354a9d6](354a9d6))
* **ecommerce:** remove query to non-existing field (backport [#31771](#31771)) ([#31773](#31773)) ([8737c10](8737c10))
* getting error to show sales invoice group or print rep… (backport [#31756](#31756)) ([#31767](#31767)) ([53b9d61](53b9d61))
* incorrect produced-qty in production-plan-item (backport [#31706](#31706)) ([#31861](#31861)) ([010a0ca](010a0ca))
* incorrect rate in BOM exploded items (backport [#31513](#31513)) ([#31864](#31864)) ([abe1894](abe1894))
* intercompany SO throws exception ([1d1f12f](1d1f12f))
* linter (backport [#31763](#31763)) ([#31766](#31766)) ([3092131](3092131))
* Make expense account editable in Purchase Receipt Item (backport [#31730](#31730)) ([#31878](#31878)) ([b637d4d](b637d4d))
* Make expense account editable in Subcontracting Receipt Item (backport [#31848](#31848)) ([#31870](#31870)) ([aa5aaa1](aa5aaa1))
* not able to issue expired batches ([ce5fc5b](ce5fc5b))
* posting_date of linked vouchers should not affect outstanding ([0faa7b0](0faa7b0))
* **projects:** Add missing comma ([623f56a](623f56a))
* set `billing_address` for purchases in `get_party_details` ([5a28ba8](5a28ba8))
* set `company_address` for purchases in `party.js` ([4c82533](4c82533))
* specify allowed doctype in queries (backport [#31761](#31761)) ([#31764](#31764)) ([6dce122](6dce122))
* Transit filter for Default Target Warehouse in SE (backport [#31839](#31839)) ([#31873](#31873)) ([04d3571](04d3571))
developmentforpeople pushed a commit to Ayuda-Efectiva/erpnext that referenced this pull request Jan 26, 2023
@mergify @deepeshgarg007
@s-aga-r @developmentforpeople
fix: Make expense account editable in Purchase Receipt Item (backport f…
7c37c1a 
…rappe#31730) (frappe#31879)

* fix: Make expense account editable in Purchase Receipt Item (frappe#31730)

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
(cherry picked from commit 1a65089)

# Conflicts:
#	erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json

* chore: conflicts

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
developmentforpeople pushed a commit to Ayuda-Efectiva/erpnext that referenced this pull request Jan 26, 2023
@frappe-bot @developmentforpeople
chore(release): Bumped to Version 13.36.4
2c80dab 
## [13.36.4](frappe/erpnext@v13.36.3...v13.36.4) (2022-08-18)

### Bug Fixes

* check item_code in all rows of po_items (backport [frappe#31741](frappe#31741)) ([frappe#31843](frappe#31843)) ([ba8dc89](frappe@ba8dc89))
* conflicts ([41b8563](frappe@41b8563))
* contact search in request for quotation (backport [frappe#31828](frappe#31828)) ([frappe#31841](frappe#31841)) ([2a615af](frappe@2a615af))
* incorrect produced-qty in production-plan-item (backport [frappe#31706](frappe#31706)) ([frappe#31862](frappe#31862)) ([7ddb332](frappe@7ddb332))
* incorrect rate in BOM exploded items (backport [frappe#31513](frappe#31513)) ([frappe#31865](frappe#31865)) ([3274e76](frappe@3274e76))
* Make expense account editable in Purchase Receipt Item (backport [frappe#31730](frappe#31730)) ([frappe#31879](frappe#31879)) ([4775c42](frappe@4775c42))
* not able to issue expired batches ([7ee75ff](frappe@7ee75ff))
* set `billing_address` for purchases in `get_party_details` ([a7d66fa](frappe@a7d66fa))
* set `company_address` for purchases in `party.js` ([d1de4b0](frappe@d1de4b0))
* Transit filter for Default Target Warehouse in SE (backport [frappe#31839](frappe#31839)) ([frappe#31874](frappe#31874)) ([b0917aa](frappe@b0917aa))
* use old style for `_dict.update` ([15654aa](frappe@15654aa))
@barredterra barredterra mentioned this pull request Mar 7, 2023
Closed
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-aga-r s-aga-r s-aga-r approved these changes

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees

@s-aga-r s-aga-r

Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@deepeshgarg007 @s-aga-r