Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linter #31763

Merged
merged 1 commit into from
Aug 3, 2022
Merged

fix: linter #31763

merged 1 commit into from
Aug 3, 2022

Conversation

dj12djdjs
Copy link
Collaborator

This linter has been failing for some time now.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #31763 (d314d59) into develop (590e91b) will increase coverage by 0.61%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #31763      +/-   ##
===========================================
+ Coverage    62.70%   63.32%   +0.61%     
===========================================
  Files          813      813              
  Lines        57506    57506              
===========================================
+ Hits         36062    36413     +351     
+ Misses       21444    21093     -351     
Impacted Files Coverage Δ
.../report/accounts_receivable/accounts_receivable.py 72.44% <ø> (+1.55%) ⬆️
...eport/item_variant_details/item_variant_details.py 31.32% <0.00%> (-53.02%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...t/product_bundle_balance/product_bundle_balance.py 79.54% <0.00%> (-15.91%) ⬇️
erpnext/accounts/party.py 77.59% <0.00%> (-4.49%) ⬇️
...eorder_level/itemwise_recommended_reorder_level.py 88.88% <0.00%> (-3.71%) ⬇️
...e/asset_value_adjustment/asset_value_adjustment.py 87.95% <0.00%> (-3.62%) ⬇️
erpnext/stock/reorder_item.py 74.16% <0.00%> (-0.84%) ⬇️
erpnext/stock/doctype/batch/batch.py 83.33% <0.00%> (-0.62%) ⬇️
...xt/e_commerce/doctype/website_item/website_item.py 48.36% <0.00%> (-0.41%) ⬇️
... and 24 more

@ankush ankush merged commit 9c580dd into frappe:develop Aug 3, 2022
@ankush ankush added the backport version-14-hotfix backport to version 14 label Aug 3, 2022
@mergify mergify bot mentioned this pull request Aug 3, 2022
mergify bot pushed a commit that referenced this pull request Aug 3, 2022
(cherry picked from commit 9c580dd)
ankush pushed a commit that referenced this pull request Aug 3, 2022
fix: linter (#31763)

(cherry picked from commit 9c580dd)

Co-authored-by: Devin Slauenwhite <devin.slauenwhite@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 18, 2022
## [14.0.1](v14.0.0...v14.0.1) (2022-08-18)

### Bug Fixes

* add asset repair to accounting dimension list ([65bb1d8](65bb1d8))
* Add dimension section in subcontracting doctypes (backport [#31849](#31849)) ([#31877](#31877)) ([50ad612](50ad612))
* check item_code in all rows of po_items (backport [#31741](#31741)) ([#31842](#31842)) ([82f1dd2](82f1dd2))
* contact search in request for quotation (backport [#31828](#31828)) ([#31840](#31840)) ([74664a3](74664a3))
* delete custom fields on deletion of inventory dimension ([354a9d6](354a9d6))
* **ecommerce:** remove query to non-existing field (backport [#31771](#31771)) ([#31773](#31773)) ([8737c10](8737c10))
* getting error to show sales invoice group or print rep… (backport [#31756](#31756)) ([#31767](#31767)) ([53b9d61](53b9d61))
* incorrect produced-qty in production-plan-item (backport [#31706](#31706)) ([#31861](#31861)) ([010a0ca](010a0ca))
* incorrect rate in BOM exploded items (backport [#31513](#31513)) ([#31864](#31864)) ([abe1894](abe1894))
* intercompany SO throws exception ([1d1f12f](1d1f12f))
* linter (backport [#31763](#31763)) ([#31766](#31766)) ([3092131](3092131))
* Make expense account editable in Purchase Receipt Item (backport [#31730](#31730)) ([#31878](#31878)) ([b637d4d](b637d4d))
* Make expense account editable in Subcontracting Receipt Item (backport [#31848](#31848)) ([#31870](#31870)) ([aa5aaa1](aa5aaa1))
* not able to issue expired batches ([ce5fc5b](ce5fc5b))
* posting_date of linked vouchers should not affect outstanding ([0faa7b0](0faa7b0))
* **projects:** Add missing comma ([623f56a](623f56a))
* set `billing_address` for purchases in `get_party_details` ([5a28ba8](5a28ba8))
* set `company_address` for purchases in `party.js` ([4c82533](4c82533))
* specify allowed doctype in queries (backport [#31761](#31761)) ([#31764](#31764)) ([6dce122](6dce122))
* Transit filter for Default Target Warehouse in SE (backport [#31839](#31839)) ([#31873](#31873)) ([04d3571](04d3571))
@dj12djdjs dj12djdjs deleted the fix-linter branch November 14, 2022 22:37
@barredterra barredterra mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants