Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect produced-qty in production-plan-item #31706

Merged
merged 6 commits into from
Aug 17, 2022
Merged

fix: incorrect produced-qty in production-plan-item #31706

merged 6 commits into from
Aug 17, 2022

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Jul 26, 2022

Source/Reference: ISS-22-23-01217

Work Order(s) for Sub-Assembly Items was updating the Production Plan Item (FG) Produced Qty.

@s-aga-r s-aga-r force-pushed the fix/production-plan/completed-qty branch from 062b8e2 to 7992ae8 Compare July 27, 2022 11:13
@codecov
Copy link

codecov bot commented Jul 27, 2022 •
edited
Loading

Codecov Report

Merging #31706 (f55a87c) into develop (0047e18) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #31706      +/-   ##
===========================================
- Coverage    63.41%   63.05%   -0.37%     
===========================================
  Files          813      813              
  Lines        57530    57530              
===========================================
- Hits         36483    36275     -208     
- Misses       21047    21255     +208
Impacted Files Coverage Δ
...cturing/doctype/production_plan/production_plan.py 74.86% <ø> (ø)
...rial_no_valuation/incorrect_serial_no_valuation.py 59.64% <0.00%> (-36.85%) ⬇️
.../report/delayed_item_report/delayed_item_report.py 60.78% <0.00%> (-35.30%) ⬇️
...e_sales_analytics/supplier_wise_sales_analytics.py 59.01% <0.00%> (-31.15%) ⬇️
...tch_item_expiry_status/batch_item_expiry_status.py 67.92% <0.00%> (-24.53%) ⬇️
...wise_balance_history/batch_wise_balance_history.py 67.79% <0.00%> (-22.04%) ⬇️
...ext/accounts/report/balance_sheet/balance_sheet.py 36.36% <0.00%> (-21.82%) ⬇️
...em_wise_sales_register/item_wise_sales_register.py 50.45% <0.00%> (-11.37%) ⬇️
...rpnext/accounts/doctype/shareholder/shareholder.py 80.00% <0.00%> (-10.00%) ⬇️
...saction/incorrect_balance_qty_after_transaction.py 88.37% <0.00%> (-9.31%) ⬇️
... and 27 more

@s-aga-r s-aga-r merged commit 538cd6f into frappe:develop Aug 17, 2022
mergify bot pushed a commit that referenced this pull request Aug 17, 2022
@s-aga-r @mergify
fix: incorrect produced-qty in production-plan-item (#31706)
678fdfe 
(cherry picked from commit 538cd6f)
@mergify mergify bot mentioned this pull request Aug 17, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 17, 2022
@s-aga-r @mergify
fix: incorrect produced-qty in production-plan-item (#31706)
c59860f 
(cherry picked from commit 538cd6f)
@mergify mergify bot mentioned this pull request Aug 17, 2022
Merged
s-aga-r added a commit that referenced this pull request Aug 17, 2022
@mergify @s-aga-r
fix: incorrect produced-qty in production-plan-item (backport #31706) (…
010a0ca 
…#31861)

fix: incorrect produced-qty in production-plan-item (#31706)

(cherry picked from commit 538cd6f)

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
s-aga-r added a commit that referenced this pull request Aug 17, 2022
@mergify @s-aga-r
fix: incorrect produced-qty in production-plan-item (backport #31706) (…
7ddb332 
…#31862)

fix: incorrect produced-qty in production-plan-item (#31706)

(cherry picked from commit 538cd6f)

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Aug 18, 2022
@frappe-bot
chore(release): Bumped to Version 13.36.4
bafa3ce 
## [13.36.4](v13.36.3...v13.36.4) (2022-08-18)

### Bug Fixes

* check item_code in all rows of po_items (backport [#31741](#31741)) ([#31843](#31843)) ([ba8dc89](ba8dc89))
* conflicts ([41b8563](41b8563))
* contact search in request for quotation (backport [#31828](#31828)) ([#31841](#31841)) ([2a615af](2a615af))
* incorrect produced-qty in production-plan-item (backport [#31706](#31706)) ([#31862](#31862)) ([7ddb332](7ddb332))
* incorrect rate in BOM exploded items (backport [#31513](#31513)) ([#31865](#31865)) ([3274e76](3274e76))
* Make expense account editable in Purchase Receipt Item (backport [#31730](#31730)) ([#31879](#31879)) ([4775c42](4775c42))
* not able to issue expired batches ([7ee75ff](7ee75ff))
* set `billing_address` for purchases in `get_party_details` ([a7d66fa](a7d66fa))
* set `company_address` for purchases in `party.js` ([d1de4b0](d1de4b0))
* Transit filter for Default Target Warehouse in SE (backport [#31839](#31839)) ([#31874](#31874)) ([b0917aa](b0917aa))
* use old style for `_dict.update` ([15654aa](15654aa))
frappe-pr-bot pushed a commit that referenced this pull request Aug 18, 2022
@frappe-bot
chore(release): Bumped to Version 14.0.1
028e939 
## [14.0.1](v14.0.0...v14.0.1) (2022-08-18)

### Bug Fixes

* add asset repair to accounting dimension list ([65bb1d8](65bb1d8))
* Add dimension section in subcontracting doctypes (backport [#31849](#31849)) ([#31877](#31877)) ([50ad612](50ad612))
* check item_code in all rows of po_items (backport [#31741](#31741)) ([#31842](#31842)) ([82f1dd2](82f1dd2))
* contact search in request for quotation (backport [#31828](#31828)) ([#31840](#31840)) ([74664a3](74664a3))
* delete custom fields on deletion of inventory dimension ([354a9d6](354a9d6))
* **ecommerce:** remove query to non-existing field (backport [#31771](#31771)) ([#31773](#31773)) ([8737c10](8737c10))
* getting error to show sales invoice group or print rep… (backport [#31756](#31756)) ([#31767](#31767)) ([53b9d61](53b9d61))
* incorrect produced-qty in production-plan-item (backport [#31706](#31706)) ([#31861](#31861)) ([010a0ca](010a0ca))
* incorrect rate in BOM exploded items (backport [#31513](#31513)) ([#31864](#31864)) ([abe1894](abe1894))
* intercompany SO throws exception ([1d1f12f](1d1f12f))
* linter (backport [#31763](#31763)) ([#31766](#31766)) ([3092131](3092131))
* Make expense account editable in Purchase Receipt Item (backport [#31730](#31730)) ([#31878](#31878)) ([b637d4d](b637d4d))
* Make expense account editable in Subcontracting Receipt Item (backport [#31848](#31848)) ([#31870](#31870)) ([aa5aaa1](aa5aaa1))
* not able to issue expired batches ([ce5fc5b](ce5fc5b))
* posting_date of linked vouchers should not affect outstanding ([0faa7b0](0faa7b0))
* **projects:** Add missing comma ([623f56a](623f56a))
* set `billing_address` for purchases in `get_party_details` ([5a28ba8](5a28ba8))
* set `company_address` for purchases in `party.js` ([4c82533](4c82533))
* specify allowed doctype in queries (backport [#31761](#31761)) ([#31764](#31764)) ([6dce122](6dce122))
* Transit filter for Default Target Warehouse in SE (backport [#31839](#31839)) ([#31873](#31873)) ([04d3571](04d3571))
developmentforpeople pushed a commit to Ayuda-Efectiva/erpnext that referenced this pull request Jan 26, 2023
@mergify @s-aga-r @developmentforpeople
fix: incorrect produced-qty in production-plan-item (backport frappe#…
a568eea 
…31706) (frappe#31862)

fix: incorrect produced-qty in production-plan-item (frappe#31706)

(cherry picked from commit 538cd6f)

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
developmentforpeople pushed a commit to Ayuda-Efectiva/erpnext that referenced this pull request Jan 26, 2023
@frappe-bot @developmentforpeople
chore(release): Bumped to Version 13.36.4
2c80dab 
## [13.36.4](frappe/erpnext@v13.36.3...v13.36.4) (2022-08-18)

### Bug Fixes

* check item_code in all rows of po_items (backport [frappe#31741](frappe#31741)) ([frappe#31843](frappe#31843)) ([ba8dc89](frappe@ba8dc89))
* conflicts ([41b8563](frappe@41b8563))
* contact search in request for quotation (backport [frappe#31828](frappe#31828)) ([frappe#31841](frappe#31841)) ([2a615af](frappe@2a615af))
* incorrect produced-qty in production-plan-item (backport [frappe#31706](frappe#31706)) ([frappe#31862](frappe#31862)) ([7ddb332](frappe@7ddb332))
* incorrect rate in BOM exploded items (backport [frappe#31513](frappe#31513)) ([frappe#31865](frappe#31865)) ([3274e76](frappe@3274e76))
* Make expense account editable in Purchase Receipt Item (backport [frappe#31730](frappe#31730)) ([frappe#31879](frappe#31879)) ([4775c42](frappe@4775c42))
* not able to issue expired batches ([7ee75ff](frappe@7ee75ff))
* set `billing_address` for purchases in `get_party_details` ([a7d66fa](frappe@a7d66fa))
* set `company_address` for purchases in `party.js` ([d1de4b0](frappe@d1de4b0))
* Transit filter for Default Target Warehouse in SE (backport [frappe#31839](frappe#31839)) ([frappe#31874](frappe#31874)) ([b0917aa](frappe@b0917aa))
* use old style for `_dict.update` ([15654aa](frappe@15654aa))
@barredterra barredterra mentioned this pull request Mar 7, 2023
Closed
@s-aga-r s-aga-r deleted the fix/production-plan/completed-qty branch April 15, 2023 10:01
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees

@rohitwaghchaure rohitwaghchaure

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@s-aga-r @rohitwaghchaure @marination