fix: do not allow to cancel incomplete reposting #40224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitwaghchaure
added
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Mar 2, 2024
(cherry picked from commit 72ac56b) # Conflicts: # erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py
mergify bot
pushed a commit
that referenced
this pull request
Mar 2, 2024
(cherry picked from commit 72ac56b) # Conflicts: # erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py
This was referenced Mar 2, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
# [14.65.0](v14.64.0...v14.65.0) (2024-03-06) ### Bug Fixes * account validation error on bank account after editing existing bank account ([8b3c809](8b3c809)) * allow gain/loss for Journals against Journals ([52e1c2f](52e1c2f)) * do not allow to cancel incomplete reposting (backport [#40224](#40224)) ([#40229](#40229)) ([091d6f3](091d6f3)) * don't override reference exchange rate ([e25ec41](e25ec41)) * handle partial invoice against provisional entry ([5f23614](5f23614)) * incorrect exchange rate if JE has multi parties ([1b5a237](1b5a237)) * incorrect TCS on customer and suppliers with same name ([af56846](af56846)) * make use of 'flt' to prevent really low precision exc gain/loss ([c1a0ac6](c1a0ac6)) * make warning for previously existing SO an alert ([c8b817c](c8b817c)) * over billing qty along with rate ([14d9d29](14d9d29)) * **Project:** filter department by company ([646b55e](646b55e)) * provisional reverse entry amount ([e62c49d](e62c49d)) * rate change on changing of the qty (backport [#40241](#40241)) ([#40242](#40242)) ([b937c4b](b937c4b)) * **setup:** avoid duplicate entry for Analytics role (backport [#40183](#40183)) ([#40184](#40184)) ([035c90c](035c90c)) ### Features * add company filter to child table field ([38baf8d](38baf8d))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
# [15.16.0](v15.15.0...v15.16.0) (2024-03-06) ### Bug Fixes * allow editable accounting dimensions for repostable doctypes ([cd24a2a](cd24a2a)) * allow gain/loss for Journals against Journals ([d8cf6ba](d8cf6ba)) * check child rows before update ([e20c1ac](e20c1ac)) * disable editable account heads ([c55c0f7](c55c0f7)) * do not allow to cancel incomplete reposting (backport [#40224](#40224)) ([#40230](#40230)) ([63209f4](63209f4)) * don't override reference exchange rate ([4513d83](4513d83)) * handle partial invoice against provisional entry ([87596e6](87596e6)) * ignore self on GL account validation for Bank Account ([1947a67](1947a67)) * include Debit To/Credit To account while fetching advance ([23d7a1f](23d7a1f)) * incorrect exchange rate if JE has multi parties ([b785901](b785901)) * incorrect TCS on customer and suppliers with same name ([d74647d](d74647d)) * make use of 'flt' to prevent really low precision exc gain/loss ([9057bff](9057bff)) * make warning for previously existing SO an alert ([4f9b194](4f9b194)) * over billing qty along with rate ([00d410c](00d410c)) * **Project:** filter department by company ([13e3343](13e3343)) * provisional reverse entry amount ([0182b95](0182b95)) * rate change on changing of the qty (backport [#40241](#40241)) ([#40243](#40243)) ([1d42171](1d42171)) * remove free item row only if pricing rule matches ([6352bfe](6352bfe)) * report path from the Item and Putaway Rule list (backport [#40190](#40190)) ([#40266](#40266)) ([c7b96df](c7b96df)) * serial no valuation rate (backport [#40221](#40221)) ([#40223](#40223)) ([85ae9ee](85ae9ee)) * **setup:** avoid duplicate entry for Analytics role (backport [#40183](#40183)) ([#40185](#40185)) ([9cb8d33](9cb8d33)) * test for repost accounting in JVs ([1634955](1634955)) * test for reposting pi ([6230bbc](6230bbc)) * uom wise price in sales or purchase transaction (backport [#40216](#40216)) ([#40225](#40225)) ([b398cc6](b398cc6)) ### Features * add company filter to child table field ([0ede99b](0ede99b)) * add patch for making repostable dimension fields editable ([4b57126](4b57126)) * allow on submit for selected fields ([6c3b5bb](6c3b5bb)) * repost ledger button in JV ([e5eeb21](e5eeb21)) * update after submit in JV ([cdab3fa](cdab3fa)) * validate before allowing repost ([8585cfc](8585cfc)) ### Performance Improvements * serial and batch bundle valuation (reposting) (backport [#40255](#40255)) ([#40262](#40262)) ([93f3af7](93f3af7))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the repost item valuation is in Queued or In Progress state, then don't allow user to cancel it.