Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rate change on changing of the qty #40241

Merged
merged 1 commit into from
Mar 2, 2024
Merged

fix: rate change on changing of the qty #40241

merged 1 commit into from
Mar 2, 2024

Conversation

rohitwaghchaure
Copy link
Collaborator

Steps to replicate issue

  1. Create the purchase receipt for item A with qty as 20 and price list rate as 3,550.00
  2. Add the discount amount as "210" > rate will set as 3,440.00 > save and submit
  3. Make the purchase receipt against the above purchase order
  4. Change the qty from 20 to 21
  5. You will notice that the rate has changed from from 3,440.00 to 3,340.02

@rohitwaghchaure rohitwaghchaure merged commit e7d7077 into frappe:develop Mar 2, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Mar 2, 2024
@rohitwaghchaure @mergify
fix: rate change on changing of the qty (#40241)
885ab00 
(cherry picked from commit e7d7077)
@mergify mergify bot mentioned this pull request Mar 2, 2024
Merged
mergify bot pushed a commit that referenced this pull request Mar 2, 2024
@rohitwaghchaure @mergify
fix: rate change on changing of the qty (#40241)
d3b2f9d 
(cherry picked from commit e7d7077)
@mergify mergify bot mentioned this pull request Mar 2, 2024
Merged
rohitwaghchaure added a commit that referenced this pull request Mar 2, 2024
@mergify @rohitwaghchaure
fix: rate change on changing of the qty (backport #40241) (#40242)
b937c4b 
fix: rate change on changing of the qty (#40241)

(cherry picked from commit e7d7077)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
rohitwaghchaure added a commit that referenced this pull request Mar 2, 2024
@mergify @rohitwaghchaure
fix: rate change on changing of the qty (backport #40241) (#40243)
1d42171 
fix: rate change on changing of the qty (#40241)

(cherry picked from commit e7d7077)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
mergify bot added a commit that referenced this pull request Mar 2, 2024
@mergify
fix: rate change on changing of the qty (backport #40241) (#40242)
60dea6e 
fix: rate change on changing of the qty (#40241)

(cherry picked from commit e7d7077)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
(cherry picked from commit b937c4b)
frappe-pr-bot pushed a commit that referenced this pull request Mar 6, 2024
@frappe-bot
chore(release): Bumped to Version 14.65.0
b424a18 
# [14.65.0](v14.64.0...v14.65.0) (2024-03-06)

### Bug Fixes

* account validation error on bank account after editing existing bank account ([8b3c809](8b3c809))
* allow gain/loss for Journals against Journals ([52e1c2f](52e1c2f))
* do not allow to cancel incomplete reposting (backport [#40224](#40224)) ([#40229](#40229)) ([091d6f3](091d6f3))
* don't override reference exchange rate ([e25ec41](e25ec41))
* handle partial invoice against provisional entry ([5f23614](5f23614))
* incorrect exchange rate if JE has multi parties ([1b5a237](1b5a237))
* incorrect TCS on customer and suppliers with same name ([af56846](af56846))
* make use of 'flt' to prevent really low precision exc gain/loss ([c1a0ac6](c1a0ac6))
* make warning for previously existing SO an alert ([c8b817c](c8b817c))
* over billing qty along with rate ([14d9d29](14d9d29))
* **Project:** filter department by company ([646b55e](646b55e))
* provisional reverse entry amount ([e62c49d](e62c49d))
* rate change on changing of the qty (backport [#40241](#40241)) ([#40242](#40242)) ([b937c4b](b937c4b))
* **setup:** avoid duplicate entry for Analytics role (backport [#40183](#40183)) ([#40184](#40184)) ([035c90c](035c90c))

### Features

* add company filter to child table field ([38baf8d](38baf8d))
frappe-pr-bot pushed a commit that referenced this pull request Mar 6, 2024
@frappe-bot
chore(release): Bumped to Version 15.16.0
eb9b2e8 
# [15.16.0](v15.15.0...v15.16.0) (2024-03-06)

### Bug Fixes

* allow editable accounting dimensions for repostable doctypes ([cd24a2a](cd24a2a))
* allow gain/loss for Journals against Journals ([d8cf6ba](d8cf6ba))
* check child rows before update ([e20c1ac](e20c1ac))
* disable editable account heads ([c55c0f7](c55c0f7))
* do not allow to cancel incomplete reposting (backport [#40224](#40224)) ([#40230](#40230)) ([63209f4](63209f4))
* don't override reference exchange rate ([4513d83](4513d83))
* handle partial invoice against provisional entry ([87596e6](87596e6))
* ignore self on GL account validation for Bank Account ([1947a67](1947a67))
* include Debit To/Credit To account while fetching advance ([23d7a1f](23d7a1f))
* incorrect exchange rate if JE has multi parties ([b785901](b785901))
* incorrect TCS on customer and suppliers with same name ([d74647d](d74647d))
* make use of 'flt' to prevent really low precision exc gain/loss ([9057bff](9057bff))
* make warning for previously existing SO an alert ([4f9b194](4f9b194))
* over billing qty along with rate ([00d410c](00d410c))
* **Project:** filter department by company ([13e3343](13e3343))
* provisional reverse entry amount ([0182b95](0182b95))
* rate change on changing of the qty (backport [#40241](#40241)) ([#40243](#40243)) ([1d42171](1d42171))
* remove free item row only if pricing rule matches ([6352bfe](6352bfe))
* report path from the Item and Putaway Rule list (backport [#40190](#40190)) ([#40266](#40266)) ([c7b96df](c7b96df))
* serial no valuation rate (backport [#40221](#40221)) ([#40223](#40223)) ([85ae9ee](85ae9ee))
* **setup:** avoid duplicate entry for Analytics role (backport [#40183](#40183)) ([#40185](#40185)) ([9cb8d33](9cb8d33))
* test for repost accounting in JVs ([1634955](1634955))
* test for reposting pi ([6230bbc](6230bbc))
* uom wise price in sales or purchase transaction (backport [#40216](#40216)) ([#40225](#40225)) ([b398cc6](b398cc6))

### Features

* add company filter to child table field ([0ede99b](0ede99b))
* add patch for making repostable dimension fields editable ([4b57126](4b57126))
* allow on submit for selected fields ([6c3b5bb](6c3b5bb))
* repost ledger button in JV ([e5eeb21](e5eeb21))
* update after submit in JV ([cdab3fa](cdab3fa))
* validate before allowing repost ([8585cfc](8585cfc))

### Performance Improvements

* serial and batch bundle valuation (reposting) (backport [#40255](#40255)) ([#40262](#40262)) ([93f3af7](93f3af7))
@ishanloya ishanloya mentioned this pull request Mar 6, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rohitwaghchaure