Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add in some indexes #40590

Merged
merged 1 commit into from
Mar 22, 2024
Merged

perf: add in some indexes #40590

merged 1 commit into from
Mar 22, 2024

Conversation

akhilnarang
Copy link
Member

Add in some missing indices, adding them down dropped some calls down from ~864 seconds to ~20 seconds - support ticket 11452

Sales Invoice Item.purchase_order
Delivery Note Item.purchase_order

`Sales Invoice Item.purchase_order`
`Delivery Note Item.purchase_order`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@s-aga-r s-aga-r merged commit 1cd38c8 into frappe:develop Mar 22, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Mar 22, 2024
`Sales Invoice Item.purchase_order`
`Delivery Note Item.purchase_order`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
(cherry picked from commit 1cd38c8)

# Conflicts:
#	erpnext/selling/doctype/sales_order_item/sales_order_item.json
#	erpnext/stock/doctype/delivery_note_item/delivery_note_item.json
mergify bot pushed a commit that referenced this pull request Mar 22, 2024
`Sales Invoice Item.purchase_order`
`Delivery Note Item.purchase_order`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
(cherry picked from commit 1cd38c8)
s-aga-r added a commit that referenced this pull request Mar 22, 2024
* perf: add in some indexes (#40590)

`Sales Invoice Item.purchase_order`
`Delivery Note Item.purchase_order`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
(cherry picked from commit 1cd38c8)

# Conflicts:
#	erpnext/selling/doctype/sales_order_item/sales_order_item.json
#	erpnext/stock/doctype/delivery_note_item/delivery_note_item.json

* chore: `conflicts`

* chore: `conflicts`

---------

Co-authored-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
s-aga-r pushed a commit that referenced this pull request Mar 22, 2024
perf: add in some indexes (#40590)

`Sales Invoice Item.purchase_order`
`Delivery Note Item.purchase_order`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
(cherry picked from commit 1cd38c8)

Co-authored-by: Akhil Narang <me@akhilnarang.dev>
@akhilnarang akhilnarang deleted the add-index branch March 22, 2024 04:59
frappe-pr-bot pushed a commit that referenced this pull request Mar 27, 2024
# [14.66.0](v14.65.8...v14.66.0) (2024-03-27)

### Bug Fixes

* achieved targets for sales partners ([f9ab763](f9ab763))
* Add default finance book check in P&L statement ([4485121](4485121))
* incorrect total qty in job card ([fb252ec](fb252ec))
* pass empty string email content of pos invoice ([ee7bd98](ee7bd98))
* permissions during bulk transaction logs ([99faafb](99faafb))
* rate not fetching from the item price ([9b3c4ac](9b3c4ac))
* rate reset to zero ([2f839fb](2f839fb))
* remove microsecond from posting datetime ([#40017](#40017)) ([c3f9338](c3f9338))
* show correct variance for durations with no vouchers ([fe3bee4](fe3bee4))
* style for tax breakup ([e922ac7](e922ac7))
* use Text Editor for rendering tax breakup table ([bba1ac5](bba1ac5))
* validate gl for previous fiscal year ([82b6133](82b6133))
* wrong buying amount if delivered and billed qty varies ([2b31113](2b31113))

### Features

* bisect doctype ([5ad3918](5ad3918))
* nodes doctype ([6afb6ff](6afb6ff))

### Performance Improvements

* add in some indexes (backport [#40590](#40590)) ([#40604](#40604)) ([390d3a6](390d3a6))
* new column posting datetime in SLE to optimize stock ledger related queries ([5e68ebd](5e68ebd))
frappe-pr-bot pushed a commit that referenced this pull request Mar 27, 2024
# [15.18.0](v15.17.6...v15.18.0) (2024-03-27)

### Bug Fixes

* Add default finance book check in P&L statement ([f087159](f087159))
* Batch No is mandatory while making manufacture entry ([a638c9c](a638c9c))
* Book depreciation until the asset disposal date and removed unwanted commits ([2d7ff5d](2d7ff5d))
* Cannot read properties of undefined (reading 'rate') ([d287ed5](d287ed5))
* existing batch from different warehouse not showing in the dropdown ([79d0478](79d0478))
* incorrect total qty in job card ([68d57c3](68d57c3))
* item not coming in quick entry ([008894d](008894d))
* permissions during bulk transaction logs ([6e6ca42](6e6ca42))
* pick list not picked qty less than 1 ([5310ec3](5310ec3))
* rate not fetching from the item price ([fd02060](fd02060))
* rate reset to zero ([4636ef0](4636ef0))
* remove faulty translation ([#40667](#40667)) ([afa930f](afa930f))
* style for tax breakup ([501b09a](501b09a))
* translatability of bom configurator labels ([cf49cec](cf49cec))
* Turkish translations ([#40650](#40650)) ([17a0876](17a0876))
* use serial/batch fields for subcontracting receipt and in transit stock entry ([9ec24bc](9ec24bc))
* use Text Editor for rendering tax breakup table ([a95bb27](a95bb27))
* validate gl for previous fiscal year ([4b973b2](4b973b2))
* validation error for the subcontracting receipt ([23ae82d](23ae82d))
* wrong buying amount if delivered and billed qty varies ([c224240](c224240))

### Features

* bisect doctype ([884a18f](884a18f))
* nodes doctype ([bfccfa4](bfccfa4))

### Performance Improvements

* add in some indexes (backport [#40590](#40590)) ([#40605](#40605)) ([f66cf7d](f66cf7d))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants