Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect qty picked in the pick list #41378

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented May 8, 2024

Issue

  • Create a product with batch and expiry on.

  • Do the material receipt for the above product in 2 batches in same warehouse location. Say 200 qty can be split in 100 qty of one batch and expiry and 100 qty of second batch and expiry.

  • Create 1 sales order with 10 quantity and create another sales order with 110 quantity.

  • Create picklist for 1st sales order, it will have 10 quantity of batch 1.

  • Create another picklist of 2nd sales order, it will show a pop up as “20 units of Item 1 is picked in another pick list” as seen in screenshot below and this pick list will only have 90 qty of batch 1. Whereas it should have taken 90 qty from batch 1 and 20 qty from batch 2.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 8, 2024
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-pick-list-incorrect-qty-picked branch from 499840e to bf77b2f Compare May 8, 2024 09:26
@rohitwaghchaure rohitwaghchaure added backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels May 8, 2024
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-pick-list-incorrect-qty-picked branch from bf77b2f to e33f4f7 Compare May 8, 2024 09:46
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-pick-list-incorrect-qty-picked branch from e33f4f7 to 5048379 Compare May 8, 2024 11:51
@rohitwaghchaure rohitwaghchaure merged commit 5ed1b6b into frappe:develop May 8, 2024
13 checks passed
mergify bot pushed a commit that referenced this pull request May 8, 2024
rohitwaghchaure added a commit that referenced this pull request May 8, 2024
fix: incorrect qty picked in the pick list (#41378)

(cherry picked from commit 5ed1b6b)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request May 9, 2024
# [15.23.0](v15.22.2...v15.23.0) (2024-05-09)

### Bug Fixes

* Add PO reference ([c417b0c](c417b0c))
* correct ordered qty on SO when removing PO item - v15 ([#41342](#41342)) ([5c1043f](5c1043f))
* Cost center not getting saved in PSOA ([fbbc0af](fbbc0af))
* Do not deduct TCS for opening invoices ([1999b7a](1999b7a))
* filter validation for batch-wise balance history report (backport [#41356](#41356)) ([#41361](#41361)) ([913cea0](913cea0))
* future subscripition updates ([b27a55e](b27a55e))
* GL Entries against orders as an advance ([e49a401](e49a401))
* incorrect qty picked in the pick list (backport [#41378](#41378)) ([#41381](#41381)) ([a293ec0](a293ec0))
* incorrect query for Purchase Invoice rate in GP ([20daae4](20daae4))
* **Item:** allow UOM conversion for non-stock items (backport [#41267](#41267)) ([#41346](#41346)) ([cd3ca1e](cd3ca1e))
* Merge debit and credit in transaction currency while merging gle with similar head ([9a58823](9a58823))
* missing Item Name on Save for Quotation created from Item (backport [#41233](#41233)) ([#41304](#41304)) ([6491577](6491577))
* Patch to fix the incorrect debit and credit in transaction currency ([f7e165b](f7e165b))
* Patch to remove cancelled asset capitalization from asset ([a755540](a755540))
* pick list with multiple batch issue (backport [#41335](#41335)) ([#41338](#41338)) ([1b1dfa8](1b1dfa8))
* pricing rule rounding ([b93828c](b93828c))
* Purchase Invoice gain loss gl entry for periodic inventory ([0513481](0513481))
* resolved conflict ([5039f45](5039f45))
* resolved conflict ([81afdcf](81afdcf))
* search for item price in stock UOM (backport [#41075](#41075)) ([#41313](#41313)) ([112f96b](112f96b))
* update project URLs (backport [#41331](#41331)) ([#41332](#41332)) ([bb619a6](bb619a6))

### Features

* **Item Price:** make UOM mandatory (backport [#40588](#40588)) ([#41312](#41312)) ([cab0e30](cab0e30))

### Performance Improvements

* index on item code for the Pick List Item doctype (backport [#41357](#41357)) ([#41364](#41364)) ([bba738f](bba738f))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant