fix: missing Item Name on Save for Quotation created from Item #41233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FHenry
added a commit
to scopen-coop/erpnext
that referenced
this pull request
Apr 29, 2024
…item_name_missing_on_quotation_from_item
|
I don't understand the failed pre-commit test from prettier This not OK according all others code lines around and it's not consistent with the required JS object designed by this call... @s-aga-r or @rohitwaghchaure If I run the pre-commit hook locally I have the same things, but it's not consistent, or is it a new standard ? In this case should I change all call to frm.make_methods all over ERPNExt ? |
|
@s-aga-r Ok, then, I let prettier do his job, and push the PR agin. Thanks |
s-aga-r
added
backport version-14-hotfix
s-aga-r
approved these changes
May 2, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2024
* fix: missing Item Name on Save for Quotation created from Item * fix: missing Item Name on Save for Quotation created from Item (cherry picked from commit c8e92cb)
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2024
* fix: missing Item Name on Save for Quotation created from Item * fix: missing Item Name on Save for Quotation created from Item (cherry picked from commit c8e92cb)
s-aga-r
pushed a commit
that referenced
this pull request
May 6, 2024
…ort #41233) (#41304) fix: missing Item Name on Save for Quotation created from Item (#41233) * fix: missing Item Name on Save for Quotation created from Item * fix: missing Item Name on Save for Quotation created from Item (cherry picked from commit c8e92cb) Co-authored-by: HENRY Florian <florian.henry@open-concept.pro>
s-aga-r
pushed a commit
that referenced
this pull request
May 6, 2024
…ort #41233) (#41303) fix: missing Item Name on Save for Quotation created from Item (#41233) * fix: missing Item Name on Save for Quotation created from Item * fix: missing Item Name on Save for Quotation created from Item (cherry picked from commit c8e92cb) Co-authored-by: HENRY Florian <florian.henry@open-concept.pro>
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 9, 2024
## [14.69.1](v14.69.0...v14.69.1) (2024-05-09) ### Bug Fixes * added brand column in Warehouse wise Item Balance Age and Value … (backport [#41280](#41280)) ([#41281](#41281)) ([d727c52](d727c52)) * Cost center not getting saved in PSOA ([e82ea12](e82ea12)) * filter validation for batch-wise balance history report (backport [#41356](#41356)) ([#41360](#41360)) ([339256b](339256b)) * incorrect query for Purchase Invoice rate in GP ([93b30d9](93b30d9)) * missing Item Name on Save for Quotation created from Item (backport [#41233](#41233)) ([#41303](#41303)) ([a26ae64](a26ae64)) * pricing rule rounding ([d2ce927](d2ce927)) * reset rate for serial batch supplied items ([#41293](#41293)) ([cd33199](cd33199)) ### Performance Improvements * index on item code for the Pick List Item doctype (backport [#41357](#41357)) ([#41362](#41362)) ([4647ec8](4647ec8))
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 9, 2024
# [15.23.0](v15.22.2...v15.23.0) (2024-05-09) ### Bug Fixes * Add PO reference ([c417b0c](c417b0c)) * correct ordered qty on SO when removing PO item - v15 ([#41342](#41342)) ([5c1043f](5c1043f)) * Cost center not getting saved in PSOA ([fbbc0af](fbbc0af)) * Do not deduct TCS for opening invoices ([1999b7a](1999b7a)) * filter validation for batch-wise balance history report (backport [#41356](#41356)) ([#41361](#41361)) ([913cea0](913cea0)) * future subscripition updates ([b27a55e](b27a55e)) * GL Entries against orders as an advance ([e49a401](e49a401)) * incorrect qty picked in the pick list (backport [#41378](#41378)) ([#41381](#41381)) ([a293ec0](a293ec0)) * incorrect query for Purchase Invoice rate in GP ([20daae4](20daae4)) * **Item:** allow UOM conversion for non-stock items (backport [#41267](#41267)) ([#41346](#41346)) ([cd3ca1e](cd3ca1e)) * Merge debit and credit in transaction currency while merging gle with similar head ([9a58823](9a58823)) * missing Item Name on Save for Quotation created from Item (backport [#41233](#41233)) ([#41304](#41304)) ([6491577](6491577)) * Patch to fix the incorrect debit and credit in transaction currency ([f7e165b](f7e165b)) * Patch to remove cancelled asset capitalization from asset ([a755540](a755540)) * pick list with multiple batch issue (backport [#41335](#41335)) ([#41338](#41338)) ([1b1dfa8](1b1dfa8)) * pricing rule rounding ([b93828c](b93828c)) * Purchase Invoice gain loss gl entry for periodic inventory ([0513481](0513481)) * resolved conflict ([5039f45](5039f45)) * resolved conflict ([81afdcf](81afdcf)) * search for item price in stock UOM (backport [#41075](#41075)) ([#41313](#41313)) ([112f96b](112f96b)) * update project URLs (backport [#41331](#41331)) ([#41332](#41332)) ([bb619a6](bb619a6)) ### Features * **Item Price:** make UOM mandatory (backport [#40588](#40588)) ([#41312](#41312)) ([cab0e30](cab0e30)) ### Performance Improvements * index on item code for the Pick List Item doctype (backport [#41357](#41357)) ([#41364](#41364)) ([bba738f](bba738f))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When create a Quotation from Item dashboard, select a customer and click on Save
=> Error : missing Item Name and UOM
As all other make method, the Quotation doctype missing his open_form() call
Note to reviewer : if merge, please backport to version-15 and version-14