Skip to content

feat: add PokéAPI proxy #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 18, 2023
Merged

feat: add PokéAPI proxy #465

merged 16 commits into from
Oct 18, 2023

Conversation

@scissorsneedfoodtoo
Copy link
Contributor

@scissorsneedfoodtoo scissorsneedfoodtoo commented Sep 14, 2023

Checklist:

@socket-security
Copy link

socket-security bot commented Sep 14, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
node-cache 5.1.2 None +1 72.4 kB erdii
axios 1.4.0 None +0 1.74 MB jasonsaayman

@scissorsneedfoodtoo scissorsneedfoodtoo mentioned this pull request Sep 20, 2023
Merged
2 tasks
@scissorsneedfoodtoo scissorsneedfoodtoo marked this pull request as ready for review September 20, 2023 05:24
@scissorsneedfoodtoo
feat: get basic proxy working
62a3d38
@scissorsneedfoodtoo
fix: refactor project to something closer to domain driven design
6162aca
@scissorsneedfoodtoo
fix: set default CACHE_TTL_MINUTES in sample.env
be14527
@scissorsneedfoodtoo
feat: add content and styling for landing proxy landing page
f2287a5
@scissorsneedfoodtoo
feat: dockerize PokéAPI proxy
8d14f4e
@scissorsneedfoodtoo
fix: use hours to set ttl for caching, update sample env vars
b6f410b
@scissorsneedfoodtoo
feat: add note to landing page about the format for pokémon with sex …
dc4a470 
…symbols as part of their name
@scissorsneedfoodtoo
feat: add middleware and utility function cache and validate all poké…
290b375 
…mon names and ids served by PokéAPI
@scissorsneedfoodtoo
feat: cache by id and name whenever fetching a valid pokémon from Pok…
add8b6f 
…éAPI
@scissorsneedfoodtoo
fix: simplify middleware and error handling, prettify code
44b5a55
@scissorsneedfoodtoo
feat: add route to get all pokemon names and routes, refactor to impr…
c70dccc 
…ove caching
@scissorsneedfoodtoo
feat: add ids to the list of all valid pokemon
d50ffa0
@scissorsneedfoodtoo
feat: add /pokemon route description and examples to the landing page
b148a18
@scissorsneedfoodtoo
feat: update README.md
5c45ad6
@scissorsneedfoodtoo
fix: add Dockerfile, set TTL env var
e340c75
@scissorsneedfoodtoo
fix: rename function to get all resources from /pokemon endpoint
36ba96e
@scissorsneedfoodtoo
Copy link
Contributor Author

scissorsneedfoodtoo commented Oct 18, 2023

Note: fixed merge conflicts in docker-compose.yml and port-map.json. Just needed to fix some overlap between the pokeapi-proxy and pokemon-search-app entries.

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit b478bb2 into freeCodeCamp:main Oct 18, 2023
@scissorsneedfoodtoo scissorsneedfoodtoo deleted the feat/add-pokeapi-proxy branch October 18, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raisedadead raisedadead raisedadead approved these changes

Assignees

No one assigned

Labels

front 3 2023

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scissorsneedfoodtoo @raisedadead