gfxlib: palette [get] using #103
Merged
+345
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when mapping 32 & 64 bit functions for PALETTE [GET] USING, check the data type pointed to choose one of LONG PTR, LONGINT PTR, INTEGER PTR - tests/gfx/palette.bas added to test PALETTE GET [USING] - add tests for BYREF pointer variables for palettes and image buffers
dkl
approved these changes
Sep 25, 2018
Member
dkl
left a comment
dkl
left a comment
There was a problem hiding this comment.
Ok, nice - looks like a big part of the problem was the missing typeDeref() for the size check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sf.net bug report #883 PALETTE [GET] USING failes using [u]long[int] types depending on platform
fb.net forum discussion FB palette array datatypes