Skip to content

Conversation

@jayrm
Copy link
Member

@jayrm jayrm commented Sep 26, 2018

  • fixes sf.net bug #866 fbc throws lexer errors in comments stating with $

- fixes sf.net bug #866 fbc throws lexer errors in comments stating with $
- -lang qb|deprecated|fblite should not be looking for "/'" multiline comment starters in single line comments
@jayrm
Copy link
Member Author

jayrm commented Sep 27, 2018

In the first commit,
there is probably a cleaner way to fix this, to allow suffixes in comments, but it gets the job done to fix sf.net bug 866

In the second commit,
I noticed that lexing of comments varies between dialects. In -lang fb, single line comments are treated as single line comments only. In the other dialects, single line comments are lexed for "/'" multi-line comments. I don't see any reason it should vary between dialects. This change may break old codes having multiline comment comment tags "/'" starting in single line comments.

@jayrm jayrm merged commit 945df0e into freebasic:master Oct 7, 2018
@jayrm jayrm deleted the comments branch October 7, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants