Skip to content

rtlib: wstring concat and assign buffer overrun #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2019
Merged

rtlib: wstring concat and assign buffer overrun #147

merged 1 commit into from
May 20, 2019

Conversation

@jayrm
Copy link
Member

@jayrm jayrm commented May 20, 2019

  • When using concatenate and assign operator &= on fixed length wstring buffer, the null terminator can be overwritten causing a buffer overrun on a subsequent operation.
  • fixed using fb_wstr_copy() which explicitly writes the null terminator
  • tests added

fixes #145

@jayrm
rtlib: wstring concat and assign buffer overrun
8c0250b 
- When using concatenate and assign operator &= on fixed length wstring buffer, the null terminator can be overwritten causing a buffer overrun on a subsequent operation.
- fixed using fb_wstr_copy() which explicitly writes the null terminator
- tests added
@jayrm jayrm merged commit 799e8d4 into freebasic:master May 20, 2019
@jayrm jayrm deleted the wstring-buffer-overrun branch May 20, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wstring concat and assign buffer overrun

1 participant

@jayrm