gfxlib2: Allow long data types with SCREENINFO, IMAGEINFO, SCREENCONTROL #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change revisits 2 previous bug reports and proposes solving the overload ambiguity by requiring that certain LONGINT parameters must be given:
Most of the underlying data types for image and screen data are of the fb LONG type (32 bits). And over time since the fbc upgrades to 64-bit support the tendency for image size & colour information has tended towards using the LONG types.
However, because the datatypes are passed BYREF, passing 32-bit and 64-bit data types is not interchangeable and requires an overloaded function if both are to be permitted.
This change proposes the following:
For 64-bit data types
For 32-bit data types:
LONG and LONGINT types can not be mixed as there is only 2 versions of the overloads.
In the case where SCREENCONTROL returns a pointer, a pointer sized data type will unambiguously resolve to the 32-bit or 64-bit API's.
Details of the API change: