doc: Convert to pcre2 from obsolete pcre (pcre3) #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libpcre (a.k.a pcre3) is obsolete in favour of pcre2 by upstream. While pcre is still available, it is being removed from several linux distributions [1] [2] - Change CRegex to use the new version and remove inclusion of the old pcre library. - Remove inclib "pcre" from fbchkdoc. Note: not replaced with pcre2 here as this should be included from the pcre2.bi header Tested on linux with only libpcre2 installed 1. https://fedoraproject.org/wiki/Changes/PcreDeprecation 2. https://lists.debian.org/debian-devel/2025/01/msg00621.html
After changing doc/libfbdoc to pcre2, the travis build fails due to missing library
jayrm
reviewed
Feb 18, 2025
Member
|
After fixing CRegex.bas:111 no more compile warnings. Tested on windows and works ok for me to build documentation. If you could fix that up that would be great, then I'll merge in. Thanks. |
- fix typo in PR: free compile context - Change CRegex.bas to use pcre2 since the libpcre (a.k.a pcre3) is obsolete in favour of pcre2 by upstream (Ahmad Khalifa) - update changelog.txt
Member
|
I am feeling impatient today, I will make the edit and update the changelog.txt. Thanks for the PR. |
Contributor
Author
|
Well spotted, yes, that was definitely meant to _free() not _create(). And thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libpcre (a.k.a pcre3) is obsolete in favour of pcre2 by upstream. While pcre is still available, it is being removed from several linux distributions [1] [2]
Tested on linux with only libpcre2 installed