Skip to content

Fixes: #709, off by one error #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2014
Merged

Fixes: #709, off by one error #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
048151a
Fixes: #709, off by one error
mudhairless Jan 17, 2014
4a05651
Updated changelog with 709 fix.
mudhairless Jan 17, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ Version 0.91.0:
- fbc crashed after showing the error message when using -vec 1|2 without -fpu sse
- ASM backend: Sgn(LongInt) returned wrong values
- C backend: Extern "Windows-MS" is now supported, including DLL exports (stdcall procedures without @N suffix)

- #709: format() adds erroneous thousands delimiter, was affecting all number strings that were multiple of 3.

Version 0.90.1:

Expand Down
2 changes: 1 addition & 1 deletion src/rtlib/str_format.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ int fb_hProcessMask
DBG_ASSERT( IndexFix!=LenFix );
pszAdd = FixPart + IndexFix;
if( pInfo->has_thousand_sep ) {
int remaining = LenFix - IndexFix;
int remaining = LenFix - IndexFix - 1;
if( (remaining % 3)==0 ) {
if( did_thousandsep ) {
did_thousandsep = FALSE;
Expand Down