fbdoc & tools update Feb 2018 #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the tools in to a single module cmd_opts.bas
…moved pages marked for delete from the set of pages to check
…E !!!, and -html option to write 'delete.html' helper file to delete pages from the wiki.
jayrm
force-pushed
the
manual-feb-2018
branch
from
578f20c to
0272b85
Compare
dkl
reviewed
Feb 25, 2018
doc/fbchkdoc/delextra.bas
Outdated
| dim chk as string = "!!! DELETE ME !!!" | ||
|
|
||
| sBody = LoadFileAsString( filename ) | ||
| if( left( ucase( ltrim( sBody, any " " & chr(9))), len( chk ) ) = chk ) then |
There was a problem hiding this comment.
This if could be solved out, in favour of return (left(...) = chk)
doc/fbchkdoc/delextra.bas
Outdated
|
|
||
| pagename = left( d, len(d) - len(".wakka") ) | ||
|
|
||
| if( filehash.test( lcase(d) ) = FALSE ) then |
There was a problem hiding this comment.
maybe this if can be turned into a function, then e.g. var remove = shouldRemove(d)
doc/fbchkdoc/delextra.bas
Outdated
| dim as string cache_dir, def_cache_dir, web_cache_dir, dev_cache_dir | ||
| dim as integer i = 1, isgit = FALSE, nodelete = FALSE | ||
| '' from cmd_opts.bas | ||
| extern cmd_opt_help as boolean |
There was a problem hiding this comment.
extern declarations can be moved into a header file, like function declarations, to avoid mismatching signatures.
…header to prevent mismatches in signatures
…oughout all the tools
|
dkl, thanks for the notes. I appreciate you giving up your free time to do that. I gave the delextra tool a once over with your suggestions and I see how I can improve the code in other tools (next month). |
dkl
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fbdoc & tools update for February 2018