boolean: don't allow NEG unary op '-' on boolean data types #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jayrm
commented
May 21, 2018
jayrm
commented
- boolean: don't allow NEG unary op '-' on boolean data types
- negative booleans were allowed for compatibility with fbc test suite (prior to Jan 2018)
- can be removed now since test-suite has been re-written
- this change stacks on PR Fix #878: select case as const #80, only because original bug was related to boolean
… Case As const' - jump tables generated by SELECT CASE AS CONST use bias/span internally, instead of minval/maxval - SELECT CASE AS CONST respects data type used when parsing CASE range values - CASE range values can be mix of signed & unsigned constants
…n SELECT CASE AS CONST.
…anged() range table
- if there was some other error parsing the CASE expression, expression could be NULL
- test overflow warnings for SELECT CASE AS CONST - test the function of parser-decl-symbtype.bas:cConstIntExprRanged()
- negative booleans were allowed for compatibility with fbc test suite (prior to Jan 2018) - can be removed now since test-suite has been re-written
dkl
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.