Skip to content

Conversation

@tkchia
Copy link
Contributor

@tkchia tkchia commented May 25, 2018

No description provided.

@jayrm
Copy link
Member

jayrm commented May 26, 2018

What system/platform were you running on to notice this problem?
Thanks

@tkchia
Copy link
Contributor Author

tkchia commented May 26, 2018

Hello @jayrm, hello @dkl,

Actually I found the issues by eye, while trying to see if I could port FreeBASIC to a 16-bit platform.

The cpuid handling issue shows up (under a debugger) when I run the DJGPP port of fbc under FreeDOS in QEMU. Under QEMU, cpuid with eax == 1 gives eax (family/model/stepping) as 0x663, and edx (feature flags) as 0x0781abfd. This results in detected_cpu being set to 0x67b1abfd (with two feature bits being set when they should not be).

Thank you!

@jayrm jayrm merged commit 537e842 into freebasic:master May 26, 2018
@jayrm
Copy link
Member

jayrm commented May 26, 2018

Good eye! Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants