Add Byref Initializers of Byref Variables #89
Conversation
jayrm
commented
Jun 20, 2018
jayrm
commented
- added hResolveRefToRefInitializer() called from hCheckAndBuildByrefInitializer()
- allows initializing a reference variable by referring to another reference variable.
- was discussed briefly in forum topic Dim Byref Syntax
- hCMPI was generate invalid ASM if operands were IMM (constant) and OFS (offset to shared/static) - dim shared X as integer: if( @x <> 0 ) then ... to produce the error
src/compiler/emit_x86.bas
Outdated
| ostr = "cmp " + dst + COMMA + src | ||
| outp ostr | ||
|
|
||
| '' immediate and offset? it's invalid for CMP so use a temp reg |
There was a problem hiding this comment.
That's perfect. Almost the same problem. Will revert emit_x86.bas and let IR handle it.
src/compiler/emit_x86.bas
Outdated
| '' immediate and offset? it's invalid for CMP so use a temp reg | ||
| if( (svreg->typ = IR_VREGTYPE_IMM) and (dvreg->typ = IR_VREGTYPE_OFS) ) then | ||
|
|
||
| dim reg as integer, isfree as integer, rname as string |
There was a problem hiding this comment.
inner rname is shadowing the outer rname here, might be better to split into an extra function
src/compiler/parser-decl-var.bas
Outdated
|
|
||
| if( expr andalso astIsDEREF( expr ) ) then | ||
| if( expr->l andalso astIsVAR( expr->l ) ) then | ||
| if( expr->l->sym andalso symbIsRef( expr->l->sym ) ) then |
There was a problem hiding this comment.
It could be helpful to also check symbIsVar, since the symbIsRef flag can apply to other symbol types too, i.e. procedures for "return byref", and looking at astNewVAR() it refers to the procedure symbol in case of function pointers.
There was a problem hiding this comment.
Added symbIsVar check. Thanks. I think for the correct sym.
| @@ -1,4 +1,4 @@ | |||
| ' TEST_MODE : COMPILE_ONLY_FAIL | |||
| ' TEST_MODE : COMPILE_ONLY_OK | |||
There was a problem hiding this comment.
we can probably remove this now, since the scenario is better covered by the new unit test
- Fix bad code generated for comparisons such as IF @globalvar = 0 THEN - add tests to /tests/expressions/address-comparison.bas
2 participants
