Skip to content

Conversation

@saulery
Copy link
Contributor

@saulery saulery commented Jul 17, 2018

Hello,

This pull-request provides a fix to IUP samples for 64 bit compliance and a clean use of attributs setting with a byValue parameter.

What's your prefered entry point for contribs? Github repository, SF repository, other, pull-request, formated patch...?

I intend to contrib an update of IUP binding. Does anyone already work on this subject?

Regards,

--
LkpPo

@rversteegen
Copy link
Member

I am not certain, but aren't FB bindings, including for IUP, generated with fbfrog, using the scripts in the fbbindings repository at https://github.com/dkl/fbbindings ?
If so, manually editing bindings instead of running the fbbindings script would be a good way to waste your time: there's a good chance you wouldn't need to do anything else in order to generate updated bindings.
However I see that dkl has marked that repository unmaintained.

None of that relates to this pull request, which is for the samples.

@saulery
Copy link
Contributor Author

saulery commented Jul 18, 2018

I'm a newcomer and don't know that. It would be a very good news if bindings are done with fbfrog. https://github.com/dkl/fbbindings is tagged UNMAINTAINED. What's the real status of this project?

Thanks for your hints.

@jayrm
Copy link
Member

jayrm commented Aug 5, 2018

The creator of fbfrog, dkl, is currently not maintaining the project. However, the project is still valid in that the last set of fbc header/library bindings was created using the project. Ideally, we (developers and user community) would continue to build on the work already done, updating the source build.

@rversteegen
Copy link
Member

OK thanks.

Can this be merged? It looks fine to me. Although I don't know IUP and didn't test this change.

@dkl dkl merged commit 056bc94 into freebasic:master Aug 6, 2018
@saulery
Copy link
Contributor Author

saulery commented Aug 6, 2018

Thanks!

I tried to update fbbindings packages with a cygwin 64bits env. and hit a lot of broken things.

Maybe cygwin is not the right build env. for this task.

It seems also that fbfrog have been changed and the makefile rules are not in sync with fbfrog. Some rules are broken, others don't output the same bi files, others output empty bi files.

If someone has commit rights I can send a PR for broken links and minors things for starting.

An other place to talk about this?

Regards,

@saulery saulery deleted the iup-sample-fix branch August 7, 2018 00:00
@dkl
Copy link
Member

dkl commented Aug 7, 2018

Yea, it would be better to talk about this in the forum. I might be able to help with some points.

@saulery
Copy link
Contributor Author

saulery commented Aug 7, 2018

I re-posted at https://www.freebasic.net/forum/viewforum.php?f=14 and stay for moderation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants