-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python script that tests notebooks. #42
Conversation
Address #32. The test has a list of expected errors. The script runs each notebook and checks that it has the expected number of errors, and that each error contains a given substring.
Nice! 💯 Two thoughts:
(e.g. this is what the Python3 language unit tests have - since it takes a while to run the entire test suite, it provides an option to only run parts of the test suite corresponding to the code you are actively working on.)
|
Re: 1, is there a canonical examples for this? Re: 2, the test might be broken. I was getting timeouts on my current machine so I just pushed hoping that I had gotten it right earlier. It prints out the expected and actual number of errors, so the mismatch means I didn't collect all the errors. Also, not sure if I'm going crazy, but I think I remembered seeing the number of errors vary from run to run. Keep an eye out for that. |
|
Working on fixes for the actual tests, it's just slow to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I do get the following warnings when I run the tests
[NbConvertApp] WARNING | Timeout waiting for IOPub output
Should this be fixed before merging.
I think there is a way to change the timeout- not sure what it should be. I think we should add travis (or circleci- are we using that now?) and set the timeout so that whatever we use for CI is happy. I think that we should merge this an fix that up in a later PR adding CI support. If there are no objections, I'll merge. |
Address #32.
The test has a list of expected errors. The script runs each notebook and checks that it has the expected number of errors, and that each error contains a given substring.