Skip to content

Conversation

@maroshi
Copy link

@maroshi maroshi commented May 11, 2016

Diagnose the bug cause and suggest a solution.

maroshi added 2 commits May 11, 2016 23:00
Fixed README to requires maven package (maven2 is obselete)
Fixed ant-task-maven.xml, fixed maven2 reference

Signed-off-by: Dudi Maroshi <yesh_etza@yahoo.com>
Since Maven 3 there is a required JVM attribute 
maven.multiModuleProjectDirectory
This attribute cause many issues with IDE (Eclipse/InteliJ...).
And CLI using ant as well.

Fix: Added the attribue to Maven JVM args in ant-task-maven.xml

See the issues reported here:
http://stackoverflow.com/questions/29330577/maven-3-3-1-eclipse-dmaven-multimoduleprojectdirectory-system-propery-is-not-s


Signed-off-by: Dudi Maroshi <yesh_etza@yahoo.com>
@Thynix
Copy link
Contributor

Thynix commented May 14, 2016

As you may have seen in the readme

db4o requires maven 2 and commons compress 1.10
requires maven 3

Did that change somehow?

@maroshi
Copy link
Author

maroshi commented May 14, 2016

As far as I know there is no maven build for db4o!
Greped all the db4o files, no mention to maven.
Only commons compress requires maven to build the code.

@Thynix
Copy link
Contributor

Thynix commented May 26, 2016

Oh! Whoops! Thanks for finding this!

Unfortunately I will be largely unavailable for probably the next month or so for medical reasons, so I won't be able to review this as early as I'd like.

@infinity0 @nextgens Is one of you up for reviewing this?

@ArneBab
Copy link
Contributor

ArneBab commented Jan 22, 2022

@Thynix do you still have the context for this contrib PR?

@Thynix
Copy link
Contributor

Thynix commented Jan 23, 2022

@ArneBab The bug is Fail build contrib project with maven 3.*, so this looks like changes to allow that. It's probably mergable as is, even though it's become outdated through neglect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants