Skip to content

CSS: more 1471 fixes#448

Merged
Thynix merged 2 commits intohyphanet:nextfrom
toad:css-more-1471-fixes
Jan 2, 2016
Merged

CSS: more 1471 fixes#448
Thynix merged 2 commits intohyphanet:nextfrom
toad:css-more-1471-fixes

Conversation

@toad
Copy link
Contributor

@toad toad commented Dec 28, 2015

A few minor fixes to the CSS changes. Removes some keywords that shouldn't be allowed, adds some that should. Can wait.

@Thynix
Copy link
Contributor

Thynix commented Dec 31, 2015

What does it add? I only see removing "space-between", "space-around", and "space-evenly" from "align-items". What does the "justify-items" change fix?

@Thynix
Copy link
Contributor

Thynix commented Dec 31, 2015

It removes left, center, and right - the strings are references to other array indexes.

@Thynix
Copy link
Contributor

Thynix commented Jan 2, 2016

Er, I'm wrong. I still don't understand what exactly it changes.

@Thynix
Copy link
Contributor

Thynix commented Jan 2, 2016

I think I got it now?

For it used to accept "left legacy", "center legacy", "right legacy", "legacy left", "legacy center", or "legacy right" before or after "center", "start", "end", "self-start", "self-end", "flex-start", "flex-end", "left", or "right". Instead of the former set it now only accepts "true" or "safe".

I still don't understand why though.

@Thynix
Copy link
Contributor

Thynix commented Jan 2, 2016

Why change justify-items? The spec indicates the previous values were accepted, does it not?

@toad
Copy link
Contributor Author

toad commented Jan 2, 2016

align-items doesn't accept the 3 keywords I deleted.

@Thynix
Copy link
Contributor

Thynix commented Jan 2, 2016

Okay, but what about justify-items?

@toad
Copy link
Contributor Author

toad commented Jan 2, 2016

justify-items accepts any one of the auxiliary verifiers 125, 129 and 130.

125 is auto, stretch or baseline-position.
129 is the last bit: legacy && [left|right|center]: legacy left, right legacy, center etc.

  • This is made of 128 (legacy) and 4 (left|right|center)
    That leaves 130 which should be "item-position && overflow-position?" e.g. "start true" etc.

The new code has 130 = combinations of 122 and 126. 122 is overflow-position, 126 is item-position.
The old code had 130 = combinations of 129 and 126. This is incorrect - we don't want the legacy keyword here, and there are more item-positions than left, right, center.

@Thynix Thynix merged commit 609c88c into hyphanet:next Jan 2, 2016
@Thynix
Copy link
Contributor

Thynix commented Jan 2, 2016

Alright, so. We finally got me to understand this:

<justify-items> used to accept <item-position> along with legacy && [ left | right | center ], which is incorrect. It now accepts <item-position> along with <overflow-position>, to match http://www.w3.org/TR/css3-align/#justify-items-property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants