FIX: on too low bandwidth, use min bandwidth#539
Conversation
ArneBab
force-pushed
the
do-not-die-on-too-low-bandwidth
branch
from
31427b3 to
e0d3daf
Compare
|
What changed the bandwidth limit? |
|
|
||
| int obwLimit = nodeConfig.getInt("outputBandwidthLimit"); | ||
| if (obwLimit < minimumBandwidth) { | ||
| obwLimit = minimumBandwidth; // upgrade slow nodes automatically |
There was a problem hiding this comment.
Thoughts on logging about clamping the values?
There was a problem hiding this comment.
that would be good, yes.
|
@Thynix I fear that I changed the bandwidth limit, because the existing limit did not actually suffice to keep the connections (I tried). I did not expect Freenet to just not start when the value is lower than the minimum value (seems no one expected that we might want to raise that) — the bug report took me completely by surprise… |
|
Stronger reason: Look at the connection number stats. The peak at 11 connections goes much too far to 5 (and below). More than I expect from the randomization. That means too many people don’t manage to keep the minimum of 10 connections. Compare |
|
Which commit changed the bandwidth limit? |
|
This one: ArneBab@565e7fc |
|
Oh. Whoops. I misremembered the minimum as like 12 KiB/s already. |
|
thank you! |
3 participants
I think this should have been the behaviour all along to allow us to upgrade the network to new internet connection requirements without continuously killing old nodes.
I cannot just re-use the checking function, because that must throw an exception for the config settings.