fix: Replace local gateways with remote ones when fetched from network #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where users would continue connecting to old/disabled gateways (like vega running v0.1.21) even after the gateway list was updated on the server. Changes: - When gateways are successfully fetched from the network, completely replace the local gateways instead of merging them - Save the updated gateway list to the local gateways.toml file - When --skip-load-from-network is used, continue using local gateways - Added logging to indicate when gateways are being replaced This ensures users always connect to the current active gateways during the alpha testing phase. The behavior may change once we release a stable version. Fixes the issue where users were getting "Protocol version mismatch: expected 0.1.21, got 0.1.23" because they were still connecting to the old vega gateway. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
sanity
added a commit
that referenced
this pull request
Sep 6, 2025
## Changes - fix: Check local storage directly in request_get() before network operations (#1806) - feat: Client connection refactor infrastructure (Phase 0) (#1813) - chore: Remove leftover script and config files (#1809) - fix: Duplicate file extension in config log output (#1808) - debug: Add logging to diagnose PUT contract key/hash mismatch (#1807) - deps: Update freenet-stdlib 0.1.14, rand 0.9, tokio-tungstenite 0.27 (#1795) - fix: Replace local gateways with remote ones when fetched from network (#1804) - fix: Improve protocol version mismatch error messages (#1803)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where users would continue connecting to old/disabled gateways even after the gateway list was updated on the server. Users were getting errors like "Protocol version mismatch: expected 0.1.21, got 0.1.23" because they were still connecting to the old vega gateway.
The Problem
The Solution
When gateways are successfully fetched from the network:
gateways.tomlfileWhen
--skip-load-from-networkis used:Changes
save_to_file()call to persist the updated gatewaysTesting
The fix ensures that:
This is especially important during alpha testing when we frequently update gateway versions.
[AI-assisted debugging and comment]
🤖 Generated with Claude Code