Fix request router deduplication race with PUT operations (issue #1886)

[sanity]

Summary

• Fixes request router deduplication race condition with PUT operations (issue Request router deduplication can cause race conditions with instant-completion GET/PUT operations #1886)
• Adds defensive protection for local-only PUT operations
• Adds test for concurrent GET operations to verify no race condition
• Follows same pattern as GET operations and Subscribe fix (PR Fix: WebSocket SubscribeResponse not being delivered to clients #1844)

Problem

Request router deduplication can cause race conditions when PUT operations complete very quickly:

1. Client 1 sends PUT → Router creates TX Bump syn from 1.0.91 to 1.0.92 #123
2. Operation completes instantly (no remote peers, local-only)
3. Result delivered to Client 1, TX Bump syn from 1.0.91 to 1.0.92 #123 removed from tracking
4. Client 2 sends identical PUT → Router tries to reuse TX Bump syn from 1.0.91 to 1.0.92 #123
5. Bug: TX Bump syn from 1.0.91 to 1.0.92 #123 already removed, Client 2 never receives response

This is the same pattern that affected Subscribe operations, which was fixed in PR #1844.

Solution

Add defensive protection for PUT operations that will complete locally:

• Before routing, detect if operation is local-only (no remote peers available)
• For local-only PUTs, bypass RequestRouter entirely
• Start direct PUT operation with proper transaction tracking
• Operation completes locally and delivers results normally
• Avoids router's deduplication mechanism that can cause the race

Note: GET operations already have this protection (lines 728-781 in client_events/mod.rs).

Changes

crates/core/src/client_events/mod.rs

• Add local-only detection for PUT operations (lines 401-408)
• Check closest_potentially_caching() to determine if network peers exist
• If no remote peers, start direct local PUT operation (lines 410-447)
• Register client for transaction result without router
• Execute PUT operation that will complete locally
• Remote operations continue using router for deduplication (lines 448-588)

crates/core/tests/isolated_node_regression.rs

• Add test_concurrent_get_deduplication_race: Concurrent GET from 3 clients
• Verifies all clients receive responses without race condition
• Tests the scenario described in issue Request router deduplication can cause race conditions with instant-completion GET/PUT operations #1886

Test Plan

• Run cargo test --test isolated_node_regression - all tests pass
• test_concurrent_get_deduplication_race - verifies no race with concurrent GETs
• test_isolated_node_put_get_workflow - verifies no regression
• Code compiles without warnings
• Pattern consistent with GET operations and UPDATE fix (issue UPDATE operations timeout on isolated nodes without returning UpdateResponse #1884)

Technical Notes

• Defensive fix - prevents race even if hard to reproduce in tests
• Follows same pattern as GET operations (instant-completion bypass)
• Similar to UPDATE isolated node fix (issue UPDATE operations timeout on isolated nodes without returning UpdateResponse #1884)
• Only bypasses router when certain operation will complete locally
• Maintains all existing functionality (subscriptions, error handling)
• No performance impact for normal networked operations

Related Issues

• Issue Request router deduplication can cause race conditions with instant-completion GET/PUT operations #1886 - Request router deduplication race conditions
• PR Fix: WebSocket SubscribeResponse not being delivered to clients #1844 - Subscribe fix for similar issue
• Issue UPDATE operations timeout on isolated nodes without returning UpdateResponse #1884 - UPDATE isolated node fix (similar pattern)

🤖 Generated with Claude Code

[AI-assisted debugging and comment]

[sanity]

@claude resolve conflicts

[claude]

Claude finished @sanity's task —— View job

---

Conflict Resolution Complete ✓

• Check current branch state and fetch latest changes
• Identify merge conflicts with main branch
• Update opentelemetry-otlp dependency version
• Commit and push Cargo.toml changes

Summary

I've resolved the merge conflict with the main branch by updating the dependency versions in crates/core/Cargo.toml:

Changes made:

• opentelemetry-otlp: 0.27.0 → 0.31.0
• opentelemetry_sdk: 0.29 → 0.31

What happened:
The main branch received a dependabot update (PR #1877) that bumped these OpenTelemetry dependencies. Your PR branch still had the old versions, causing a conflict.

Status:
✅ Cargo.toml updated and pushed to fix/issue-1886-router-deduplication-race

Note about Cargo.lock:
The Cargo.lock file will be automatically regenerated when CI runs or when you next build the project locally. GitHub should now recognize the conflict as resolved once the lock file is regenerated during the next build/test cycle.

If you want to regenerate Cargo.lock immediately, you can run locally:

cargo update -p opentelemetry-otlp -p opentelemetry_sdk

---

Job: [View run](https://github.com/freenet/freenet-core/actions/runs/${{ github.run_id }})
Branch: fix/issue-1886-router-deduplication-race

[Copilot]

Pull Request Overview

This PR fixes a request router deduplication race condition with PUT operations where rapid completion could leave subsequent clients without responses. The fix adds defensive protection by bypassing the router for local-only PUT operations, similar to the pattern already used for GET operations.

• Detects local-only PUT operations (no remote peers) and bypasses RequestRouter to prevent race conditions
• Adds comprehensive test case for concurrent GET operations to verify no race condition exists
• Improves error message formatting for consistency

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/core/src/client_events/mod.rs	Adds local-only PUT detection and direct operation bypass to prevent deduplication race
crates/core/tests/isolated_node_regression.rs	Adds comprehensive test for concurrent GET operations to verify race condition fix
logs/trajectory.jsonl	Adds logging entries for development tracking
.vtcode/tool-policy.json	Adds VS Code tool policy configuration
worktrees/pr-1853	Git worktree reference
.worktrees/pr1865	Git worktree reference

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[iduartgomez]

@claude add to gitignore worktrees .worktrees and logs/*

[claude]

Claude finished @iduartgomez's task —— View job

---

.gitignore Updated ✓

• Read current .gitignore file
• Add worktrees, .worktrees, and logs/* to .gitignore
• Remove accidentally committed files from git tracking
• Commit and push changes

Summary

Successfully added the requested entries to .gitignore and cleaned up accidentally committed development files:

Added to .gitignore:

• worktrees/
• .worktrees/
• logs/*

Removed from git tracking:

• .vtcode/tool-policy.json
• worktrees/pr-1853
• .worktrees/pr1859, .worktrees/pr1861, .worktrees/pr1865
• logs/trajectory.jsonl

These files will now be ignored in future commits, keeping the repository clean from local development artifacts.

---

Branch: fix/issue-1886-router-deduplication-race

[iduartgomez]

LGTM