refactor: split priority_select into module with separate test file #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splits the 2214-line priority_select.rs into a cleaner structure: - priority_select.rs (313 lines) - implementation - priority_select/tests.rs (1900 lines) - test module Uses modern Rust module style (named file + directory) rather than mod.rs pattern. This improves code organization and makes large test suites easier to navigate without affecting functionality. All 13 tests pass. No logic changes - pure refactoring. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Oct 28, 2025
|
Part of systematic file bloat reduction tracked in #2016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Splits the 2214-line
priority_select.rsinto a cleaner, more maintainable structure:priority_select.rs(313 lines) - implementation onlypriority_select/tests.rs(1900 lines) - comprehensive test moduleWhy
Large files are a code smell. While not as extreme as Bob Martin's approach, 2200+ line files become difficult to navigate and maintain. This refactoring:
module_name.rs+module_name/pattern instead ofmod.rsWhat Changed
priority_select.rs→priority_select.rs+priority_select/tests.rspub(super), etc.)Test Plan
cargo build --libcargo test --lib priority_selectcargo fmt --checkcargo clippy🤖 Generated with Claude Code