test: add freenet-test-network harnesses #2081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
iduartgomez
reviewed
Nov 13, 2025
| #[tokio::test] | ||
| async fn diagnose_connectivity_failure() { | ||
| // Build network with more relaxed settings | ||
| let result = TestNetwork::builder() |
Collaborator
There was a problem hiding this comment.
- why now we have multiple test frameworks?
- why not keep a single implementation under one place we can improve altogether?
- why not use the test macro?
- why is it in a different repo complicating integration?
please refactor and pull this in, let's stop creating more code just cause we can and re-use code instead
Collaborator
Author
There was a problem hiding this comment.
You're right, we've had a proliferation of test networks - probably a symptom of the fact that none of them exactly fit what we need. I've opened #2082 for discussion of how to consolidate.
iduartgomez
approved these changes
Nov 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
iduartgomez
force-pushed
the
feat/test-network-integration-main
branch
from
04f9049 to
1e72517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing