fix: use tempfile in test_serde_config_args for CI reliability #2194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
config::tests::test_serde_config_argstest was failing intermittently on our self-hosted CI runners with:This blocked 5 of 7 Dependabot PRs from passing CI, even though the test failure was unrelated to the dependency updates.
Root Cause
The test used
id: Some(unique_id)which triggersConfigPathsArgs::default_dirs()to create directories under/tmp/freenet-{id}. Self-hosted runners can have restrictive permissions on/tmpdirectories that prevent this.Solution
Use
tempfile::tempdir()to create a guaranteed-writable temporary directory, then explicitly setconfig_paths.config_dirandconfig_paths.data_dirto that path. This bypasses the/tmpcode path entirely.Testing
Impact
Once merged, the 5 blocked Dependabot PRs should pass CI:
[AI-assisted - Claude]