Skip to content

Homepage polish#68

Merged
Thynix merged 8 commits intohyphanet:nextfrom
Thynix:homepage-polish
Aug 9, 2016
Merged

Homepage polish#68
Thynix merged 8 commits intohyphanet:nextfrom
Thynix:homepage-polish

Conversation

@Thynix
Copy link
Copy Markdown
Contributor

@Thynix Thynix commented Jul 17, 2016

These are some changes I made at Ryan's suggestion, and some Ryan did. There are a few more changes I can add; among them are removing the SUMA award because it's old and moving the news section to the left of the top download button. I'm not sure I like the Twitter / GitHub buttons yet. Thoughts?

Thynix and others added 8 commits July 16, 2016 15:10
The fundraiser has been done for over two months thanks to Duck Duck
Go's donation.
At small resolutions like mobile devices the logo could exceed the
horizontal resolution.
The contrast with the lighter background is easier to read.
@steveatinfincia
Copy link
Copy Markdown
Collaborator

Looks good to me

@ArneBab
Copy link
Copy Markdown
Contributor

ArneBab commented Aug 7, 2016

I like the carousel, but I agree that the homepage is too cluttered and it duplicates what’s below, so I’d say go for it.

@xor-freenet
Copy link
Copy Markdown

Nice! Thanks! Conceptual ACK - would really be thankful to see this merged soon so I can build more improvements upon it. (Conceptual = Haven't read the source code, cannot justify its quality or security)

I'd also remove the Twitter / GItHub buttons, and reduce the vertical spacing next to them.
But I'd prefer this to be merged quickly if you don't have the time to do it on your own.
I'll deal with it in an upcoming PR then.

Screenshots

Old

website-old

New

website-new

xor-freenet added a commit to xor-freenet/website that referenced this pull request Aug 7, 2016
Based on branch hyphanet#68

Reasons for removal:

- The website should be focused at users, not developers, so we don't
need Github.

- People who want to follow Freenet on Twitter will just search for
Freenet on Twitter.

- They icons looked misplaced and cluttered the homepage.

Notice: The icon data is not removed because it is embedded into some
SVG library we use. It contains other stuff as well which we might still
use, and I don't think I should be editing imported libs. Will only
cause merge problems if we want to update the libs.
See assets/fonts/ionicons.svg
@Thynix
Copy link
Copy Markdown
Contributor Author

Thynix commented Aug 8, 2016

I agree on removing the buttons. I'm hoping to get this merged once I do
that, shift the download button to the right, and put the news to the left
of that. Assuming it ends up looking okay.

On Sun, Aug 7, 2016, 7:27 PM xor-freenet notifications@github.com wrote:

Nice! Thanks! Conceptual ACK - would really be thankful to see this merged
soon so I can build more improvements upon it. (Conceptual = Haven't read
the source code, cannot justify its quality or security)

I'd also remove the Twitter / GItHub buttons, and reduce the vertical
spacing next to them.
But I'd prefer this to be merged quickly if you don't have the time to do
it on your own.
I'll deal with it in an upcoming PR then.
Screenshots Old

[image: website-old]
https://cloud.githubusercontent.com/assets/78502/17466074/d258b31c-5d06-11e6-8d3d-0f65a333c603.png
New

[image: website-new]
https://cloud.githubusercontent.com/assets/78502/17466078/ed6ffc00-5d06-11e6-8775-98fa687a33ec.png


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#68 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAMM7bbifJJlMQ4NJFRWzcWvUWnI50fSks5qdmnrgaJpZM4JORax
.

@xor-freenet
Copy link
Copy Markdown

On Sunday, August 07, 2016 08:50:37 PM Steve Dougherty wrote:

I agree on removing the buttons. I'm hoping to get this merged once I do
that, shift the download button to the right, and put the news to the left
of that. Assuming it ends up looking okay.

No need to remove the buttons on your own - I've already filed a pull request
to deal with that & various other pull requests.
Before you do any further work please have a look to avoid merge/style
conflicts.

@Thynix Thynix merged commit b53da63 into hyphanet:next Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants