Homepage: Remove Twitter / GitHub buttons#71
Merged
Thynix merged 10 commits intohyphanet:nextfrom Aug 9, 2016
Merged
Conversation
The fundraiser has been done for over two months thanks to Duck Duck Go's donation.
At small resolutions like mobile devices the logo could exceed the horizontal resolution.
The contrast with the lighter background is easier to read.
homepage-polish .
Based on branch hyphanet#68 Reasons for removal: - The website should be focused at users, not developers, so we don't need Github. - People who want to follow Freenet on Twitter will just search for Freenet on Twitter. - They icons looked misplaced and cluttered the homepage. Notice: The icon data is not removed because it is embedded into some SVG library we use. It contains other stuff as well which we might still use, and I don't think I should be editing imported libs. Will only cause merge problems if we want to update the libs. See assets/fonts/ionicons.svg
Contributor
|
Merged, but we only agree on the third bullet point: they were misplaced and poorly spaced. I'm still interested in finding a place to put them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #68
Reasons for removal
Notice: The icon data is not removed because it is embedded into some SVG library we use. It contains other stuff as well which we might still use, and I don't think I should be editing imported libs. Will only cause merge problems if we want to update the libs.
See assets/fonts/ionicons.svg
Screenshots
Currently deployed old code
Base PR #68
This PR