Feat/offcanvas#115
Merged
duranmla merged 9 commits intofreenowtech:mainfrom Jun 11, 2021
div-Leo:feat/offcanvas
Merged
Conversation
added 8 commits
June 10, 2021 17:11
div-Leo
requested review from
LeonardKoch,
agonzalezUX,
duranmla,
lukahartwig,
nlopin,
rafael-sepeda and
snapsnapturtle
as code owners
div-Leo
commented
Jun 11, 2021
Comment on lines
+14
to
+19
| The Offcanvas should only contain content or flows which are related to the current page and not replace pages, therefore | ||
| its complexity level has to be simple. Consider the fullscreen state if you want to focus the users attention to the Offcanvas | ||
| content. | ||
|
|
||
| Offcanvas is responsive per default but the width can be adjusted (the default is 600px or 37.5rem). Content on the Offcanvas | ||
| is scrollable and has a space5 bounding box. |
Contributor
Author
There was a problem hiding this comment.
Maybe we need a different text here, do we have some in charge for this particular task?
Contributor
There was a problem hiding this comment.
We need to review this. @agonzalezUX @rafael-sepeda can you read this documentation?
Sadly we yet don't have preview links so can you read this file?
rafael-sepeda
approved these changes
Jun 11, 2021
duranmla
approved these changes
Jun 11, 2021
Comment on lines
+14
to
+19
| The Offcanvas should only contain content or flows which are related to the current page and not replace pages, therefore | ||
| its complexity level has to be simple. Consider the fullscreen state if you want to focus the users attention to the Offcanvas | ||
| content. | ||
|
|
||
| Offcanvas is responsive per default but the width can be adjusted (the default is 600px or 37.5rem). Content on the Offcanvas | ||
| is scrollable and has a space5 bounding box. |
Contributor
There was a problem hiding this comment.
We need to review this. @agonzalezUX @rafael-sepeda can you read this documentation?
Sadly we yet don't have preview links so can you read this file?
Contributor
Author
|
@duranmla It was just for the documentation, but for me, it's ready to go! woot woot! 💪 🚂 |
Contributor
|
🎉 This PR is included in version 1.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Add
Offcanvascomponent
Why:
We need an
Offcanvasfor this design.
How:
Add a new component
Offcanvaswhich follows the same logic of theModal.It receives the side props ("left" | "right" | "top" | "bottom") and slides in from the relative side.
Media:
See more in this video on loom
Checklist:
See this pull-request thread for more info.