Skip to content

fix(checkbox): remove outline: none;#116

Merged
duranmla merged 2 commits intomainfrom
23/checkbox-focus-state
Jun 11, 2021
Merged

fix(checkbox): remove outline: none;#116
duranmla merged 2 commits intomainfrom
23/checkbox-focus-state

Conversation

@duranmla
Copy link
Contributor

What:
Improve keyboard a11y of checkbox

Why:
Closes #23

How:
Remove the outline "none" and keep built-in one

Media:
CleanShot 2021-06-11 at 15 46 09

Checklist:

  • Ready to be merged

add an extra offset to the outline to make it "better" visible
@nlopin
Copy link
Contributor

nlopin commented Jun 11, 2021

Snapshots 😂

@duranmla duranmla merged commit 4774215 into main Jun 11, 2021
@duranmla duranmla deleted the 23/checkbox-focus-state branch June 11, 2021 14:42
github-actions bot pushed a commit that referenced this pull request Jun 11, 2021
### [1.4.3](v1.4.2...v1.4.3) (2021-06-11)

### Features

* add offcanvas component ([#115](#115)) ([c937a48](c937a48))

### Bug Fixes

* **checkbox:** preserve checkbox outline ([#116](#116)) ([4774215](4774215))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

Checkbox component is not focusable and therefore not accessible without a mouse

3 participants