Skip to content

feat: calendar refactor and multiple choices #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlanFnz merged 25 commits into from
Oct 30, 2025
Merged

feat: calendar refactor and multiple choices #558

AlanFnz merged 25 commits into from
Oct 30, 2025

Conversation

@renejfc
Copy link
Member

@renejfc renejfc commented Aug 25, 2025 •
edited
Loading

What

Refactor Calendar component from react-aria-components to react-day-picker with enhanced selection modes and improved styling

Why

This refactoring migrates from react-aria-components to react-day-picker, which provides better flexibility and more intuitive APIs for calendar functionality. The change enables support for multiple selection modes and improves the overall user experience.

How

  • Migrated Calendar component from react-aria-components to react-day-picker
  • Added support for multiple selection types: single, range, and multiple selection modes
  • Enhanced styling system with improved data attributes for better CSS targeting:
    • Added data-selected-single for single day selection
    • Added data-selected-multiple for multiple day selection
  • Enhanced range selection styling with proper border radius handling
  • Improved component architecture:
    • Created custom CalendarDayButton component with proper focus management
    • Added proper date formatting with date-fns
    • Implemented custom chevron components using existing Wave icons
  • Updated Storybook stories to demonstrate new functionality including multiple selection mode
  • Maintained API compatibility while extending functionality with new selection types

Breaking?

The refactor includes minor visual and ux changes, not necessarily breaking or "worse", i just thought that i should clear this out.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 25, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@freenow/wave@558

commit: fdc45fa

lloydaf
lloydaf approved these changes Aug 25, 2025
View reviewed changes
@renejfc renejfc self-assigned this Aug 25, 2025
@AlanFnz AlanFnz self-assigned this Oct 15, 2025
@AlanFnz AlanFnz merged commit 6bf1acf into main Oct 30, 2025
8 checks passed
@AlanFnz AlanFnz deleted the feat/calendar-multiple-choices branch October 30, 2025 08:52
github-actions bot pushed a commit that referenced this pull request Oct 30, 2025
@semantic-release-bot
chore(release): 2.48.0 [skip ci]
1fddd5c 
## [2.48.0](v2.47.1...v2.48.0) (2025-10-30)

### Features

* calendar refactor and multiple choices ([#558](#558)) ([6bf1acf](6bf1acf))
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

🎉 This PR is included in version 2.48.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlanFnz AlanFnz AlanFnz approved these changes

@Mukesh-FN Mukesh-FN Mukesh-FN approved these changes

@jonotrujillo jonotrujillo Awaiting requested review from jonotrujillo jonotrujillo is a code owner

@dornelasnelson dornelasnelson Awaiting requested review from dornelasnelson

+1 more reviewer

@lloydaf lloydaf lloydaf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@renejfc renejfc

@AlanFnz AlanFnz

Labels

released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@renejfc @lloydaf @AlanFnz @Mukesh-FN