Skip to content

CI: The Test with nox (nox-all) job is skipped when a matrix job fails #134

@llucax

Description

@llucax

What happened?

Since protection rules are set to require the "virtual" job Test with nox (nox-all), when it is skipped, the protection rule doesn't prevent the PR to be merged, so the protection rule is effectively not working at the moment.

What did you expect instead?

For a PR to not be merged if any Test with nox matrix job fails.

Affected version(s)

No response

Affected part(s)

Build script, CI, dependencies, etc. (part:tooling)

Extra information

This is fixed upstream in repo-config.

This job:

https://github.com/frequenz-floss/frequenz-client-dispatch-python/blob/ff88fd9a952eeebc949958d9c0c070acbf51d885/.github/workflows/ci.yaml#L87C3-L94

Needs to be replaced with:

https://github.com/frequenz-floss/frequenz-repo-config-python/blob/6528215e587fcec19dff05269bcae669a1ef44c2/cookiecutter/%7B%7Bcookiecutter.github_repo_name%7D%7D/.github/workflows/ci.yaml#L123-L138

Actually the same is probably true for other -all jobs, like nox-cross-arch-all.

I think it might be best to re-generate the ci.yaml file completely if it got too out of sync.

Metadata

Metadata

Assignees

No one assigned

    Labels

    part:toolingAffects the development tooling (CI, deployment, dependency management, etc.)priority:highAddress this as soon as possibletype:tech-debtImproves the project without visible changes for users

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions