Skip to content

Dispatcher doesn't disconnect with client during cleanup #145

@ela-kotulska-frequenz

Description

@ela-kotulska-frequenz

What happened?

Dispatcher doesn't disconnect with the client during cleanup (it doesn't call await self._client.disconnect() ).
https://github.com/frequenz-floss/frequenz-dispatch-python/blob/v0.x.x/src/frequenz/dispatch/_dispatcher.py#L216

It might cause error:
unclosed <socket.socket fd=22, family=1, type=1, proto=0>

What did you expect instead?

Proper cleanup

Affected version(s)

v0.6.2

Affected part(s)

Hight-level interface / Dispatcher (part:dispatcher)

Extra information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    part:dispatcherAffects the high-level dispatcher interfacepriority:❓We need to figure out how soon this should be addressedtype:bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions